Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch illegal kwds #466

Merged
merged 8 commits into from
Jul 16, 2024
Merged

Catch illegal kwds #466

merged 8 commits into from
Jul 16, 2024

Conversation

rettigl
Copy link
Member

@rettigl rettigl commented Jul 4, 2024

Addresses #363
Would still be good to add some more tests

This is based to energy_calibration_bias_shift and includes the branch flash_tests_fix, so should be merged after these two and rebased to v1feature_branch

@rettigl rettigl changed the base branch from main to energy_calibration_bias_shift July 4, 2024 20:18
@coveralls
Copy link
Collaborator

coveralls commented Jul 4, 2024

Pull Request Test Coverage Report for Build 9799510297

Details

  • 106 of 123 (86.18%) changed or added relevant lines in 17 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 92.349%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sed/diagnostics.py 1 2 50.0%
sed/loader/flash/loader.py 4 5 80.0%
sed/loader/sxp/loader.py 1 2 50.0%
sed/calibrator/energy.py 9 12 75.0%
sed/core/processor.py 1 4 25.0%
sed/loader/mpes/loader.py 4 7 57.14%
sed/calibrator/momentum.py 17 22 77.27%
Files with Coverage Reduction New Missed Lines %
sed/binning/numba_bin.py 3 87.5%
Totals Coverage Status
Change from base Build 9759204395: -0.2%
Covered Lines: 6940
Relevant Lines: 7515

💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jul 8, 2024

Pull Request Test Coverage Report for Build 9838234857

Details

  • 99 of 104 (95.19%) changed or added relevant lines in 14 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 92.578%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sed/calibrator/momentum.py 21 22 95.45%
sed/loader/mpes/loader.py 6 7 85.71%
sed/loader/sxp/loader.py 1 2 50.0%
sed/core/processor.py 2 4 50.0%
Totals Coverage Status
Change from base Build 9837231065: 0.06%
Covered Lines: 6985
Relevant Lines: 7545

💛 - Coveralls

Copy link
Member

@zain-sohail zain-sohail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I can't help but wonder if there's a more general way than doing a manual check everytime such as with use of decorators. But seems too tricky for current use case.

@rettigl
Copy link
Member Author

rettigl commented Jul 8, 2024

I can't help but wonder if there's a more general way than doing a manual check everytime such as with use of decorators. But seems too tricky for current use case.

Maybe worth checking how this is handled in other packages, but this fixes the issue for now for us.

Base automatically changed from energy_calibration_bias_shift to v1_feature_branch July 16, 2024 22:37
@rettigl rettigl merged commit 1e2ea1b into v1_feature_branch Jul 16, 2024
5 checks passed
@rettigl rettigl deleted the catch_illegal_kwds branch July 16, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants