-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch illegal kwds #466
Catch illegal kwds #466
Conversation
Pull Request Test Coverage Report for Build 9799510297Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9838234857Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I can't help but wonder if there's a more general way than doing a manual check everytime such as with use of decorators. But seems too tricky for current use case.
Maybe worth checking how this is handled in other packages, but this fixes the issue for now for us. |
Addresses #363
Would still be good to add some more tests
This is based to energy_calibration_bias_shift and includes the branch flash_tests_fix, so should be merged after these two and rebased to v1feature_branch