Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch illegal kwds arguments #363

Closed
Tracked by #462
rettigl opened this issue Mar 18, 2024 · 4 comments
Closed
Tracked by #462

Catch illegal kwds arguments #363

rettigl opened this issue Mar 18, 2024 · 4 comments

Comments

@rettigl
Copy link
Member

rettigl commented Mar 18, 2024

Catch and report all illegal kwds arguments in all relevant functions

@zain-sohail
Copy link
Member

How is illegal being defined?
We would nee dsome sort of schema to check that.

@rettigl
Copy link
Member Author

rettigl commented May 22, 2024

Any function that accepts **kwds should filter them depending on where they are passed to. This only becomes relevant, if you pass **kwds to a function that does not accept **kwds. Then you must ensure that only legal keyword arguments are being passed.

@zain-sohail
Copy link
Member

So there are two cases?

  • **kwds are passed but shouldn't be
  • **kwds are legal but some illegal ones are also passed

So I am guessing legal ones are the ones that pass the check inside the function/method?

Not sure how to approach this issue. One way would be to add decorator to each method but that doesn't seem ideal.
The other is to just perform this check at testing phase.

@zain-sohail zain-sohail mentioned this issue Jul 2, 2024
11 tasks
@rettigl
Copy link
Member Author

rettigl commented Jul 16, 2024

Closed by #466

@rettigl rettigl closed this as completed Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants