Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unified typing of df_partitions #298

Merged
merged 5 commits into from
Nov 22, 2023
Merged

unified typing of df_partitions #298

merged 5 commits into from
Nov 22, 2023

Conversation

rettigl
Copy link
Member

@rettigl rettigl commented Nov 21, 2023

This implements a small unification of the code addressing #142

@rettigl rettigl linked an issue Nov 21, 2023 that may be closed by this pull request
df_partitions as list of df partitions #142
Closed
@coveralls
Copy link
Collaborator

coveralls commented Nov 21, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6954920818

  • 7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 90.589%
Totals Coverage Status
Change from base Build 6947232406: 0.003%
Covered Lines: 5564
Relevant Lines: 6142
💛 - Coveralls

@rettigl rettigl force-pushed the dfpartitions_as_list branch from 735fd68 to 8686c43 Compare November 21, 2023 22:45
@rettigl rettigl mentioned this pull request Nov 21, 2023
Closed
zain-sohail
zain-sohail approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@zain-sohail zain-sohail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I guess that instead of casting, it'd be better to make the int into a list or another sequence.

@rettigl
Copy link
Member Author

rettigl commented Nov 22, 2023

Looks good. I guess that instead of casting, it'd be better to make the int into a list or another sequence.

Had the same idea yesterday evening, will do so.

@rettigl rettigl merged commit 2041555 into main Nov 22, 2023
5 checks passed
@rettigl rettigl deleted the dfpartitions_as_list branch November 22, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zain-sohail zain-sohail zain-sohail approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

df_partitions as list of df partitions
3 participants
@rettigl @coveralls @zain-sohail