Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

df_partitions as list of df partitions #142

Closed
rettigl opened this issue Aug 29, 2023 · 1 comment · Fixed by #298
Closed

df_partitions as list of df partitions #142

rettigl opened this issue Aug 29, 2023 · 1 comment · Fixed by #298
Assignees
@rettigl
Labels
enhancement New feature or request

Comments

@rettigl
Copy link
Member

rettigl commented Aug 29, 2023

Allow df_partitions kw argument of the compute and pre_binning methods of the processor to accept also lists/slices of dataframe partition ids, instead of just a number with the number of df partitions to use
@rettigl rettigl added the enhancement New feature or request label Aug 29, 2023
@rettigl rettigl self-assigned this Aug 29, 2023
@rettigl rettigl mentioned this issue Nov 21, 2023
Merged
@rettigl rettigl linked a pull request Nov 21, 2023 that will close this issue
unified typing of df_partitions #298
Merged
@rettigl
Copy link
Member Author

rettigl commented Nov 21, 2023

This has been working all-along. PR #298 adds some unification to the type hints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rettigl rettigl

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

unified typing of df_partitions OpenCOMPES/sed
1 participant
@rettigl