SXP loader

[rettigl]

PR for drafting an SXP loader

[rettigl]

This should more or less work now, needs to be tested with a full run. For test data upload, I am waiting for David's approval.

[coveralls]

Pull Request Test Coverage Report for Build 6909677854

• 229 of 287 (79.79%) changed or added relevant lines in 4 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.5%) to 89.865%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
tests/loader/test_loaders.py	22	26	84.62%
sed/loader/utils.py	16	21	76.19%
sed/loader/sxp/loader.py	190	239	79.5%

Totals
Change from base Build 6868190392:	-0.5%
Covered Lines:	5116
Relevant Lines:	5693

---

💛 - Coveralls

[rettigl]

This works for now. It has only a few modifications to the flash loader, but probably too many to become a single loader.
The metadata stuff is untouched as of now, this needs to be updated once it's known how it works. Also, the additions from the flash consistency check can be ported once completed, but this I would do in separate PRs.

[zain-sohail]

Generally I have seen the git blame so I got the idea where you made changes.
Is this going to be a permenant loader or it's just for your beamtime?
Because adapting flash loaders structure makes this confusing and likely unmaintainable. We should later definitely think of a solution to this.

[zain-sohail]

Lets wait for data approval before merging, I'd suggest

[rettigl]

Not sue there will be a public example dataset soon, but I'd still like to merge this and make it usable easily.

[rettigl]

Generally I have seen the git blame so I got the idea where you made changes. Is this going to be a permenant loader or it's just for your beamtime? Because adapting flash loaders structure makes this confusing and likely unmaintainable. We should later definitely think of a solution to this.

Well, In gerneral the requirements for FLASH and SXP are very similar, i.e. the train /micro/macrobunch structure etc., so it does not make sense to me to deviate too much from what we have. But I agree we need to find a way to maintain this. Either we outsource the common code into utils files, or build an intermedate FEL loader, where FLASH and SXP loader inherit from.

[zain-sohail]

Generally I have seen the git blame so I got the idea where you made changes. Is this going to be a permenant loader or it's just for your beamtime? Because adapting flash loaders structure makes this confusing and likely unmaintainable. We should later definitely think of a solution to this.

Well, In gerneral the requirements for FLASH and SXP are very similar, i.e. the train /micro/macrobunch structure etc., so it does not make sense to me to deviate too much from what we have. But I agree we need to find a way to maintain this. Either we outsource the common code into utils files, or build an intermedate FEL loader, where FLASH and SXP loader inherit from.

I think best solution is to define different classes for these different aspects and create the actual loaders to instantiate these classes