Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user definition of buffer files #281

Closed
zain-sohail opened this issue Nov 18, 2023 · 2 comments
Closed

Allow user definition of buffer files #281

zain-sohail opened this issue Nov 18, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@zain-sohail
Copy link
Member

In reference to disucssion on #264, we want to allow the user to be able to define a parquet location even if they already defined a beamtime directory already. Currently not possible.

df, df_timed = self.parquet_handler(data_parquet_dir, **kwds)

Also other such inconsistences can be discussed here.

I think important addition would be if we allow for this buffer file feature in the base loader. That way loaders can just use it if needed. Also save to parquet feature.

@zain-sohail zain-sohail added the enhancement New feature or request label Nov 18, 2023
@zain-sohail zain-sohail self-assigned this Nov 18, 2023
@zain-sohail zain-sohail mentioned this issue Nov 18, 2023
@zain-sohail
Copy link
Member Author

zain-sohail commented Dec 12, 2023

Should be easily possible after #329. Have to see what changes have to be made

@zain-sohail
Copy link
Member Author

Done in #329

parquet_dir: str | Path = None,

Also possible by changing

self.parquet_dir: str = None

before calling read_dataframe but SedProcessor wrapper won't allow that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant