This repository was archived by the owner on Mar 16, 2024. It is now read-only.
AnnePro2 EEPROM support #3
Closed
+0
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Would you be interested in adding the HT32 SPI master driver to the chibiOS-contrib project? I think it would better fit over there. Sorry for taking this long to get around to this review. (There's some code there for the HT32F165x series you can probably reference.) https://github.com/OpenAnnePro/ChibiOS-Contrib/tree/feat-ht32_support |
|
Also it would be nice to probably split this into multiple PRs by function (separate EEPROM stuff from the profile commands). Really thanks for all of this code. It just seems like a bit too much has changed in one single PR. Let me know if you have any questions |
|
Yeah, I can split it up into a few PRs, one for EEPROM and one for the profile commands. The spi driver is probably more appropriately integrated into the spi_master drive in qmk, it's roughly the same level as the code for the STM32 in that driver. |
|
Okay sounds good to me
…On Aug 18, 2020, 7:38 PM -0400, tech2077 ***@***.***>, wrote:
Yeah, I can split it up into a few PRs, one for EEPROM and one for the profile commands. The spi driver is probably more appropriately integrated into the spi_master drive in qmk, it's roughly the same level as the code for the STM32 in that driver.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
tech2077
force-pushed
the
keyboard-annepro2
branch
from
8ea4474 to
81e4e56
Compare
CyrilPeponnet
pushed a commit
to CyrilPeponnet/qmk_firmware
that referenced
this pull request
Feb 21, 2021
* added urbanvanilla keymap Urbanvanilla's keymap for massdrop/alt keyboard adds in an idle timer to turn off RGB after set amount of time. poor unsuccessful attempt at replicating a velocikey like functionality. Grave escape is enabled on ESC. * Update readme.md * updating documentation * Create readme.md * restoring default documentation * update with review changes implemented removed unnecessary lines and files. increased wait_us() parameter to 40 as was still getting chatter at 20. removed some code for the terrible rudimentary attempt at velocikey for rgb matrix * Update matrix.c * Revert "Merge pull request OpenAnnePro#3 from urbanvanilla/dev_branch" This reverts commit deb55d7, reversing changes made to ba88173. * Update keymap.c * added urbanvanilla keymap Urbanvanilla's keymap for massdrop/alt keyboard adds in an idle timer to turn off RGB after set amount of time. poor unsuccessful attempt at replicating a velocikey like functionality. Grave escape is enabled on ESC. * Update readme.md * updating documentation * Create readme.md * restoring default documentation * update with review changes implemented removed unnecessary lines and files. increased wait_us() parameter to 40 as was still getting chatter at 20. removed some code for the terrible rudimentary attempt at velocikey for rgb matrix * Update matrix.c * Revert "Merge pull request OpenAnnePro#3 from urbanvanilla/dev_branch" This reverts commit deb55d7, reversing changes made to ba88173. * Delete matrix.c * Update keyboards/massdrop/alt/keymaps/urbanvanilla/config.h Co-authored-by: Joel Challis <[email protected]> * Update keymap.c * Update keymap.c * Update keyboards/massdrop/alt/keymaps/urbanvanilla/keymap.c Co-authored-by: Ryan <[email protected]> Co-authored-by: Joel Challis <[email protected]> Co-authored-by: Ryan <[email protected]>
Jpe230
referenced
this pull request
in Jpe230/qmk_firmware
Dec 15, 2021
* [Keyboard] K6 Gateron RGB (Sonix SN32F248B) * Update info.json Corrected the layout. * K6: Update MCUConf and remove CT16.h As per requested here SonixQMK#3 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AnnePro2 EEPROM support
List of changes