urbanvanilla keymap for drop/alt #11365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
requested changes
Jan 7, 2021
urbanvanilla
commented
Jan 7, 2021
14 tasks
github-actions
bot
added
cli
|
This has a bunch of existing commits, that is messing up the diff and such. |
Urbanvanilla's keymap for massdrop/alt keyboard adds in an idle timer to turn off RGB after set amount of time. poor unsuccessful attempt at replicating a velocikey like functionality. Grave escape is enabled on ESC.
removed unnecessary lines and files. increased wait_us() parameter to 40 as was still getting chatter at 20. removed some code for the terrible rudimentary attempt at velocikey for rgb matrix
Urbanvanilla's keymap for massdrop/alt keyboard adds in an idle timer to turn off RGB after set amount of time. poor unsuccessful attempt at replicating a velocikey like functionality. Grave escape is enabled on ESC.
removed unnecessary lines and files. increased wait_us() parameter to 40 as was still getting chatter at 20. removed some code for the terrible rudimentary attempt at velocikey for rgb matrix
Co-authored-by: Joel Challis <[email protected]>
urbanvanilla
force-pushed
the
urbanvanillakeymap
branch
from
daaa8eb to
f32005b
Compare
github-actions
bot
removed
translation
documentation
python
core
via
fauxpark
requested changes
Jan 12, 2021
Co-authored-by: Ryan <[email protected]>
drashna
approved these changes
Jan 13, 2021
fauxpark
approved these changes
Jan 13, 2021
|
Thanks! |
1 similar comment
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Keymap with simple changes all in userspace for the drop/alt.
Modified matrix.c in the wait_us function to get rid of annoying key chatter that plagues this keyboard.
Implemented a really simple RGB timer that turns off RGB Matrix lighting after a set time.
Changed escape key to grave escape.
Types of Changes
Issues Fixed or Closed by This PR
Checklist