Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SVDConv] runs in infinite loop when using generate partition on SVD file without <sauNumRegions> element under <cpu> #1082 (#671) #1086

Merged

Conversation

grasci-arm
Copy link
Collaborator

fixed:

  • check for initialized value of sau num regions

…file without <sauNumRegions> element under <cpu> Open-CMSIS-Pack#1082 (Open-CMSIS-Pack#671)

fixed:
- check for initialized value of sau num regions
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #1086 (fbb5810) into main (0f66cb4) will increase coverage by 2.83%.
Report is 1 commits behind head on main.
The diff coverage is 81.25%.

❗ Current head fbb5810 differs from pull request most recent head f77193e. Consider uploading reports for the commit f77193e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1086      +/-   ##
==========================================
+ Coverage   55.17%   58.01%   +2.83%     
==========================================
  Files         116      116              
  Lines       22774    22782       +8     
  Branches    12650    12656       +6     
==========================================
+ Hits        12566    13217     +651     
+ Misses       8034     7337     -697     
- Partials     2174     2228      +54     
Flag Coverage Δ
svdconv-cov 38.38% <81.25%> (+5.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
tools/svdconv/SVDModel/src/SvdCpu.cpp 36.97% <40.00%> (+4.20%) ⬆️
tools/svdconv/SVDGenerator/src/PartitionData.cpp 66.10% <100.00%> (+66.10%) ⬆️

... and 13 files with indirect coverage changes

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Test Results

  6 files  12 suites   0s ⏱️
26 tests 26 ✔️ 0 💤 0
78 runs  78 ✔️ 0 💤 0

Results for commit f77193e.

@JonatanAntoni JonatanAntoni merged commit 2457ea2 into Open-CMSIS-Pack:main Aug 9, 2023
22 checks passed
@JonatanAntoni JonatanAntoni deleted the outbound/github#1082_2 branch August 9, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants