Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use applicationId instead of PACKAGE_NAME #642

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use applicationId instead of PACKAGE_NAME #642

wants to merge 1 commit into from

Commits on Jun 10, 2020

  1. fix: use applicationId instead of PACKAGE_NAME 

    if the cordova app has flavors (like debug and release version with different applicationId value), the PACKAGE_NAME value remains fixed to the value of the `id` in `config.xml`, and that causes problems when you try to install a different flavor of the app as there is another app (the other flavor) that already declared a push permission for that package name. 
By using the applicationId variable, each flavor will have it's own permission matching the application Id.

This was fixed in other push plugins long ago, check 
https://github.com/phonegap/phonegap-plugin-push/blob/master/plugin.xml#L31
https://github.com/Azure/azure-mobile-engagement-cordova/blob/master/plugin.xml#L140
    @jcesarmobile
    jcesarmobile authored Jun 10, 2020
    Configuration menu
    Copy the full SHA
    5ae97de View commit details
    Browse the repository at this point in the history