fix: use applicationId instead of PACKAGE_NAME #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if the cordova app has flavors (like debug and release version with different applicationId value), the PACKAGE_NAME value remains fixed to the value of the `id` in `config.xml`, and that causes problems when you try to install a different flavor of the app as there is another app (the other flavor) that already declared a push permission for that package name. By using the applicationId variable, each flavor will have it's own permission matching the application Id. This was fixed in other push plugins long ago, check https://github.com/phonegap/phonegap-plugin-push/blob/master/plugin.xml#L31 https://github.com/Azure/azure-mobile-engagement-cordova/blob/master/plugin.xml#L140
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the cordova app has flavors (like debug and release version with different applicationId value), the PACKAGE_NAME value remains fixed to the value of the
idinconfig.xml, and that causes problems when you try to install a different flavor of the app as there is another app (the other flavor) that already declared a push permission for that package name.By using the applicationId variable, each flavor will have it's own permission matching the application Id.
This was fixed in other push plugins long ago, check
https://github.com/phonegap/phonegap-plugin-push/blob/master/plugin.xml#L31
https://github.com/Azure/azure-mobile-engagement-cordova/blob/master/plugin.xml#L140
This change is