Bump Halibut to fix a polling tentacle cooperative cancellation issue causing request to time out to quickly #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… causing requests to timeout to quickly
nathanwoctopusdeploy
changed the title
| @@ -28,7 +28,7 @@ | |||
| </Otherwise> | |||
| </Choose> | |||
| <ItemGroup> | |||
| <PackageReference Include="Halibut" Version="7.0.256" /> | |||
| <PackageReference Include="Halibut" Version="7.0.270-pull-558" /> | |||
There was a problem hiding this comment.
TODO - Update when OctopusDeploy/Halibut#558 merges
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This PR bumps Halibut to fixe a bug in cooperative cancellation for Polling Requests which causes the transferring request to be cancelled after the PollingRequestQueueTimeout rather than waiting for the PollingRequestMaximumMessageProcessingTimeout
Additional integration tests have also been added to ensure this does not regress.
Related Fix a bug in cooperative cancellation for Polling Services causing a request to be cancelled before it should be
[sc-58429]
How to review this PR
Quality ✔️
Pre-requisites