Fix a bug in cooperative cancellation for Polling Services causing a request to time out to quickly #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanwoctopusdeploy
changed the title
| @@ -59,13 +59,6 @@ public static LatestClientAndLatestServiceBuilder WithInstantReconnectPollingRet | |||
| { | |||
| return builder.WithPollingReconnectRetryPolicy(() => new RetryPolicy(1, TimeSpan.Zero, TimeSpan.Zero)); | |||
| } | |||
|
|
|||
| public static LatestClientAndLatestServiceBuilder WhenTestingAsyncClient(this LatestClientAndLatestServiceBuilder builder, ClientAndServiceTestCase clientAndServiceTestCase, Action<LatestClientAndLatestServiceBuilder> action) | |||
There was a problem hiding this comment.
Removed as everything is Async
| { | ||
| return false; | ||
| } | ||
|
|
||
| using (await transferLock.LockAsync(CancellationToken.None)) |
There was a problem hiding this comment.
Ensure there is no race condition allowing a just cancelled request to be dequeued
| if (completed) | ||
| // Check if the request has already been completed or if the request has been cancelled | ||
| // to ensure we don't dequeue an already completed or already cancelled request | ||
| if (completed || pendingRequestCancellationTokenSource.IsCancellationRequested) |
There was a problem hiding this comment.
Ensure there is no race condition allowing a just cancelled request to be dequeued
3 tasks
nathanwoctopusdeploy
changed the title
…led before it should be
nathanwoctopusdeploy
force-pushed
the
sast/fix-co-operative-cancellation
branch
from
84b11a9 to
a3427ee
Compare
sburmanoctopus
pushed a commit
that referenced
this pull request
Nov 29, 2023
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This PR fixes a bug in cooperative cancellation for Polling Requests which cause the transferring request to be cancelled after the PollingRequestQueueTimeout rather than waiting for the PollingRequestMaximumMessageProcessingTimeout
[sc-58429]
How to review this PR
Quality ✔️
Pre-requisites