Fail if customer is using Legacy IIS (IIS6) #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zentron
force-pushed
the
robe/no-iis6
branch
from
3cff32f to
d491a16
Compare
zentron
force-pushed
the
robe/no-iis6
branch
from
d491a16 to
7b407f5
Compare
zentron
force-pushed
the
robe/no-iis6
branch
from
ac25679 to
168217f
Compare
APErebus
approved these changes
Sep 13, 2024
Comment on lines
65
to
68
| throw new CommandException($"Support for IIS6 is no longer supported.\r\n" | ||
| + $"Remove the {SpecialVariables.UseLegacyIisSupportForce} variable and ensure you are targeting IIS7+.\r\n" | ||
| + $"To provide a temporary work around set the `{SpecialVariables.UseLegacyIisSupportForce}` to `true`.\r\n" | ||
| + $"This capability will be very shortly removed without further warning."); |
There was a problem hiding this comment.
This doesn't make sense to me. We are telling them to remove the variable, but then tell them how to set the variable. Should we remove the 2nd line?
There was a problem hiding this comment.
Yeah maybe bad wording. 🤔 ill give it a tweak.
Originally I just failed with no recourse, but decided to add the additional fallback. The phrasing probably got a bit muddled in that change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LegacyIIS support was added many moon ago when IIS6 on Windows2003 was still supported however IIS7 on Windows 2008+ used different API.
As noted in the AutoDetect code the auto selection of this process only apples for Windows 2003 and below. Windows 2003 is no longer supported and so no customers should be relying on this code path.
Since the pending removal of this code path has never been warned, a temporary last-ditch support will be temporarily be supplied via an additional force variable.
Given the lack of support for servers that should be running IIS6, It is expected that this code will be removed within a few months.