update iis library to netcore #1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zentron
commented
Sep 12, 2024
| ? WebServerSupport.Legacy() | ||
| : WebServerSupport.AutoDetect(); | ||
|
|
||
| #if IIS_SUPPORT |
There was a problem hiding this comment.
This part of code will change once #1343 merges to change how we deal with this legacy IIS6 class
zentron
commented
Sep 12, 2024
| { | ||
| using (var serverManager = ServerManager.OpenRemote(Localhost)) |
There was a problem hiding this comment.
This method appears to fail in NetCore
dotnet/core#2691
That's fine really since we are only interacting with the localhost anyway so we dont need to use OpenRemote
zentron
force-pushed
the
robe/iis-netcore
branch
from
778c218 to
f53883e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.