Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedupe MFA requirements in chapter V2 and update text #2588

Merged
merged 20 commits into from
Feb 10, 2025
Merged

Conversation

tghosth
Copy link
Collaborator

@tghosth tghosth commented Feb 9, 2025

This Pull Request relates to issue #2587

@tghosth
Copy link
Collaborator Author

tghosth commented Feb 9, 2025

@elarlang ready for review :)

@tghosth tghosth changed the title Dedupe v2 Dedupe MFA requirements in chapter V2 Feb 9, 2025
@tghosth tghosth enabled auto-merge (rebase) February 9, 2025 09:05
@tghosth tghosth marked this pull request as draft February 9, 2025 11:36
auto-merge was automatically disabled February 9, 2025 11:36

Pull request was converted to draft

@tghosth
Copy link
Collaborator Author

tghosth commented Feb 9, 2025

(converted to draft to prevent accidental merge)

@tghosth tghosth changed the title Dedupe MFA requirements in chapter V2 Dedupe MFA requirements in chapter V2 and update text Feb 9, 2025
@tghosth tghosth mentioned this pull request Feb 9, 2025
@elarlang elarlang self-assigned this Feb 9, 2025
@elarlang
Copy link
Collaborator

elarlang commented Feb 9, 2025

First I have question:

  • 2.7.3 - maybe it is easier when this "once" stays in this requirement?

Tags to correct:

  • 2.6.1 - covers 2.2.6, but 2.2.6 does not have matching tag "covered by 2.6.1" (2.8.4 is not updated to 2.6.1)
  • 2.6.5 - modified, moved from (not added)
  • 2.8.4 - deleted, merged to
  • 2.8.3 - deleted, merged to

@tghosth
Copy link
Collaborator Author

tghosth commented Feb 10, 2025

First I have question:

* 2.7.3 - maybe it is easier when this "once" stays in this requirement?

Tags to correct:

* 2.6.1 - covers 2.2.6, but 2.2.6 does not have matching tag "covered by 2.6.1" (2.8.4 is not updated to 2.6.1)

* 2.6.5 - modified, moved from (not added)

* 2.8.4 - deleted, merged to

* 2.8.3 - deleted, merged to

Fixed tags and responded to your question here: #2587 (comment)

@tghosth
Copy link
Collaborator Author

tghosth commented Feb 10, 2025

@elarlang are you ready to approve this now?

@elarlang elarlang marked this pull request as ready for review February 10, 2025 18:51
@tghosth tghosth marked this pull request as draft February 10, 2025 18:53
@tghosth tghosth marked this pull request as ready for review February 10, 2025 18:53
@tghosth tghosth marked this pull request as draft February 10, 2025 18:54
@tghosth tghosth marked this pull request as ready for review February 10, 2025 18:58
Copy link
Member

@jmanico jmanico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to collide with my "remove ETC" PR - but that is ok. Your PR is way more complex and I can adjust my branch after this is perged.

@jmanico jmanico merged commit 7e2ac3f into master Feb 10, 2025
6 checks passed
@jmanico jmanico deleted the dedupe-v2 branch February 10, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants