Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 chapter texts #2568

Closed
elarlang opened this issue Feb 5, 2025 · 8 comments
Closed

V2 chapter texts #2568

elarlang opened this issue Feb 5, 2025 · 8 comments

Comments

@elarlang
Copy link
Collaborator

elarlang commented Feb 5, 2025

  • "NIST SP 800-63" vs "NIST SP 800-63B" mixed usage, those are different things, so we need to be sure that all the references are correct
  • Get rid of section title "NIST SP 800-63 - Modern, evidence-based authentication standard" - this is the only separate level 2 (##) title, it would be also helpful and precondition to extract section texts to JSON file, in case we want to solve Machine parseable format does not include informative text #821
  • Get rid of "We strongly urge US government agencies to review and implement NIST SP 800-63 in its entirety."
  • Some of the references to NIST sections are links and some are not.
  • When I saw the line "The requirements in this section relate to a variety of sections of NIST's Guidance, including: 4.2.1, 4.3.1, 5.2.2, and 6.1.2." I first had a question why we are referencing to authorization requirements here, but those are actually NIST numbers, not ASVS requirement numbers...

edit:

  • remove the line or smoothen the message "NIST SP 800-63 terminology can be a little confusing and we have tried to standardise the terminology to optimize for clarity, using more commonly understood terminology where possible."
@elarlang elarlang added _5.0 - prep This needs to be addressed to prepare 5.0 V2 _5.0 - draft This should be discussed once a 5.0 draft has been prepared. and removed _5.0 - prep This needs to be addressed to prepare 5.0 labels Feb 5, 2025
@jmanico
Copy link
Member

jmanico commented Feb 5, 2025

I think these are all solid suggestions. Thumbs up.

@randomstuff
Copy link
Contributor

Get rid of "We strongly urge US government agencies to review and implement NIST SP 800-63 in its entirety."

😄

@elarlang
Copy link
Collaborator Author

elarlang commented Feb 6, 2025

Get rid of "We strongly urge US government agencies to review and implement NIST SP 800-63 in its entirety."

😄

Well, the recommendation should not be read out of context :) It has already been said a few lines before ("The standard is helpful for all organizations all over the world but is particularly relevant to US agencies and those dealing with US agencies."). US agencies anyway need to follow it and they don't need to read it from the ASVS. For every other audience, it is just a noise and may make a feeling, that ASVS is US-audience oriented as well.

@tghosth tghosth added _5.0 - rc1 and removed _5.0 - draft This should be discussed once a 5.0 draft has been prepared. labels Feb 9, 2025
@tghosth
Copy link
Collaborator

tghosth commented Feb 9, 2025

"NIST SP 800-63" vs "NIST SP 800-63B" mixed usage, those are different things, so we need to be sure that all the references are correct

I have tried to tidy those up.

Get rid of section title "NIST SP 800-63 - Modern, evidence-based authentication standard" - this is the only separate level 2 (##) title, it would be also helpful and precondition to extract section texts to JSON file, in case we want to solve #821

Changed it to bold

Get rid of "We strongly urge US government agencies to review and implement NIST SP 800-63 in its entirety."

Removed

Some of the references to NIST sections are links and some are not.

Fixed.

When I saw the line "The requirements in this section relate to a variety of sections of NIST's Guidance, including: 4.2.1, 4.3.1, 5.2.2, and 6.1.2." I first had a question why we are referencing to authorization requirements here, but those are actually NIST numbers, not ASVS requirement numbers...

Added the § symbol which hopefully makes it clearer.

remove the line or smoothen the message "NIST SP 800-63 terminology can be a little confusing and we have tried to standardise the terminology to optimize for clarity, using more commonly understood terminology where possible."

Tried to clean this up

All these changes are here: 9c3f14d

@tghosth
Copy link
Collaborator

tghosth commented Feb 9, 2025

Even after #2588 is merged, this should stay open for a final review of the text.

@elarlang
Copy link
Collaborator Author

However, NIST SP 800-63 terminology can sometimes be a little hard to understand and we have therefore tried to use more commonly understood terminology where possible. to make the chapter clearer.

this "little hard to undestand" part should be turned to "is different", or the entire line can be deleted.

@tghosth
Copy link
Collaborator

tghosth commented Feb 17, 2025

However, NIST SP 800-63 terminology can sometimes be a little hard to understand and we have therefore tried to use more commonly understood terminology where possible. to make the chapter clearer.

this "little hard to undestand" part should be turned to "is different", or the entire line can be deleted.

@elarlang what do you think about #2619

@tghosth
Copy link
Collaborator

tghosth commented Mar 2, 2025

Final review changes in #2656

@tghosth tghosth closed this as completed in 3a089d1 Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants