Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for the v1 launch pattern #89

Merged
merged 4 commits into from
Apr 19, 2024

Conversation

berroar
Copy link
Contributor

@berroar berroar commented Apr 5, 2024

What is the context of this PR?

We are removing support for the formerly deprecated v1 launch pattern in runner. Updated the documentation to remove references to the v1 launch pattern and have removed the old example files. At present, only the v2 launch pattern will be supported, but naming conventions using v2 will be kept as we may need to support other launch patterns in future.

Links

Checklist

  • Changes to the spec have been added to example schemas in examples/
  • JSON Schema definitions have been updated

@berroar berroar marked this pull request as ready for review April 8, 2024 12:39
@berroar berroar requested review from a team as code owners April 8, 2024 12:39
@VirajP1002
Copy link
Contributor

VirajP1002 commented Apr 9, 2024

Looks great so far! I did notice a reference on line 55 electronic_questionnaire_runner_to_downstream.md to v1 and since it references a v1 docs that's been deleted, should this be removed?

Screenshot 2024-04-10 at 15 45 56

@berroar
Copy link
Contributor Author

berroar commented Apr 11, 2024

Looks great so far! I did notice a reference on line 55 electronic_questionnaire_runner_to_downstream.md to v1 and since it references a v1 docs that's been deleted, should this be removed?

Screenshot 2024-04-10 at 15 45 56

Removed now 👍

Copy link
Contributor

@VirajP1002 VirajP1002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! 🎉

Copy link
Contributor

@pricem14pc pricem14pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aligns with RASRM usage and understanding of the launch claims versions.

@berroar berroar merged commit 9d3efd0 into main Apr 19, 2024
1 check passed
@berroar berroar deleted the remove-support-for-v1-launch-pattern branch April 19, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants