Remove support for the v1 launch pattern #1353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berroar
force-pushed
the
remove-support-for-v1-launch-pattern
branch
from
543fde1 to
d637bef
Compare
berroar
changed the title
liamtoozer
reviewed
Apr 19, 2024
liamtoozer
reviewed
Apr 23, 2024
VirajP1002
reviewed
Apr 23, 2024
petechd
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Removes support for the v1 launch pattern in Runner (detailed here: ONSdigital/ons-schema-definitions#89). This includes removal of v1 validation of the payload on launch and the old v1 submission formats. Our Metadata structure will now always follow the v2 format, and all tests should now references the v2 pattern (previously there were a mix of v1/v2 tests).
How to review
Check that the v2 launch and submission pattern is still working as expected, and that no references to the v1 launch pattern has been missed.
Check if there are any tests that have been missed that can now be removed.
Checklist