Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrates the new PUT metadata endpoint #973

Merged
merged 12 commits into from
Apr 4, 2023

Conversation

vmilitaru
Copy link
Contributor

What

  • uses the new PUT metadata endpoint (see ONSdigital/dp-publishing-dataset-controller#51) once the dataset has been associated to a collection and the collection state is not an empty string anymore
  • reads and writes the versionEtag to the payload so that the put metadata request to be successful
  • retrieves the latest metadata, before every putMetadata call is made to make sure the latest versionEtag is passed down in the payload

NOTE - this PR to be merged only after the following two PRs have been merged:

  1. ONSdigital/dp-dataset-api#415
  2. ONSdigital/dp-publishing-dataset-controller#51

How to review

Read the code, run the tests and set up your local environment following these instructions to locally test the changes in florence .

Make sure the changes are not affecting any part of the cantabular metadata journey.

Who can review

Anyone

Copy link
Contributor

@jondewijones jondewijones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafahop rafahop merged commit bffe2e6 into develop Apr 4, 2023
@rafahop rafahop deleted the feature/integrates-put-metadata-endpoint branch April 4, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants