Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create PUT metadata endpoint #415

Merged
merged 21 commits into from
Apr 4, 2023
Merged

Create PUT metadata endpoint #415

merged 21 commits into from
Apr 4, 2023
+1,996 −461

Conversation

vmilitaru
Copy link
Contributor

What

  • add new PUT metadata endpoint which updates a predefine list of editable metadata fields (see)

  • use transactional interface from dp-mongodb

  • update swagger spec to include the new endpoint

How to review

  • check code, unit tests, component tests and swagger spec are acceptable

Who can review

anyone

@vmilitaru vmilitaru mentioned this pull request Mar 21, 2023
Merged
@rafahop rafahop changed the title Create PUT /datasets/<dataset_id>/editions/<edition>/versions/<version>/metadata endpoint Create PUT metadata endpoint Mar 23, 2023
This was referenced Mar 30, 2023
Merged
Merged
cookel2
cookel2 reviewed Mar 31, 2023
View reviewed changes
cookel2
cookel2 reviewed Mar 31, 2023
View reviewed changes
cookel2
cookel2 reviewed Mar 31, 2023
View reviewed changes
cookel2
cookel2 reviewed Mar 31, 2023
View reviewed changes
cookel2
cookel2 reviewed Mar 31, 2023
View reviewed changes
cookel2
cookel2 reviewed Mar 31, 2023
View reviewed changes
cookel2
cookel2 requested changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@cookel2 cookel2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small comments on this one @vmilitaru

@cookel2 cookel2 self-requested a review April 3, 2023 16:02
cookel2
cookel2 approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@cookel2 cookel2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafahop rafahop merged commit afa4352 into develop Apr 4, 2023
@rafahop rafahop deleted the feature/add-put-metadata-endpoint branch April 4, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cookel2 cookel2 cookel2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vmilitaru @cookel2 @rafahop