Remove /v1/unit_data from SDS_API_BASE_URL #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/services/supplementary_data.py # tests/app/services/test_request_supplementary_data.py
katie-gardner
suggested changes
Jul 21, 2023
MebinAbraham
approved these changes
Jul 21, 2023
Yuyuutsu
approved these changes
Jul 21, 2023
katie-gardner
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
The base url used for making requests to SDS was previously configured to not be the base, but the end point
v1/unit_data, preventing any future requests to other endpoints from using the env var which details this url.This PR fixes this by ensuring the env var is actually the base url of SDS and that endpoints are appended to. the base when needed by runner.
Changes
.development.env & .functional-tests.env:
SDS_API_BASE_URLnow set tohttp://localhost:5003, having had/v1/unit_dataremoved from the end of it.session.py: Imports and uses the renamed method
get_supplementary_data_v1.supplementary_data.py: Renamed method
get_supplementary_datatoget_supplementary_data_v1, as it now appends/v1/unit_datato the SDS API Base URL.doc/run-mock-sds-endpoint.md: Fixed reference to the env var
SDS_API_BASE_URLto ensure it instructs the reader to correctly set it to the base url.test_request_supplementary_data.py: Renamed usages of
get_supplementary_datatoget_supplementary_data_v1How to review
Ensure all tests are still passing.
Run Runner, Launcher and the Mock SDS and ensure mock data can still be loaded.