Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligning SDS API Base URL naming with runner #51

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

kylelawsonAND
Copy link
Contributor

What is the context of this PR?

Runner has had the SDS_API_BASE_URL env var changed to actually be a base url in this PR. This PR simply aligns the naming of the base url to match.

How to review

Ensure this version of launcher works with the above linked PR to load supplementary data.

@kylelawsonAND
Copy link
Contributor Author

Copy link
Contributor

@katie-gardner katie-gardner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct url name and all works smoothly with the Runner PR 👍

@MebinAbraham MebinAbraham merged commit 814d206 into main Jul 21, 2023
@MebinAbraham MebinAbraham deleted the sds-base-url-rename branch July 21, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants