-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate with SDS endpoint to support loading Prepop data #1114
Conversation
44306f8
to
22ef680
Compare
a8c2627
to
566a526
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still need to test functionally but some initial comments/questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A PR should be raised to merge main
into the base branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have now tested functionally and working as I would expect except for survey_id validation
…nnaire-runner into integrate-with-sds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally changes looking good 👍
I found it quite hard to functionally test as I missed a few things - now we need to update our .env file with the SDS url and if running the mock sds endpoint script in debug mode, remembering to set the working directory to runner so it can find the files
My bad really but might be useful tips to add to run instructions?
Also are the run instructions anywhere else? Thinking a readme in the doc folder or somewhere else might be good to preserve whats on the PR so people have a reference once its merged
Ah - I think the .development.env and functional tests equivalent need updating for the new env var
Agree would be good to update the .env files |
Updated now 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me. Will functionally test once i fix my runner 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor non-blocking comments but happy with readme and how its all working, and test updates, nice one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great now - nice one 👌
Co-authored-by: rmccar <[email protected]>
Changes look good to me. Runs OK! |
What is the context of this PR?
Adds the ability to integrate with the future SDS endpoint in order to be able to load Pre-populated Questionnaire data into runner.
Adds validation of the Prepop data returned by the SDS endpoint, based on the definitions outlined here: ONSdigital/sds-schema-definitions#1
As this PR only covers the initial integration, the response payload from the SDS endpoint is being validated and returned but not being used.
How to review
Set up a mock SDS endpoint using the new dev script added:
python -m scripts.mock_sds_endpoint
Ensure the new env var SDS_API_BASE_URL is set with
http://localhost:5003/v1/unit_data
.Use the
add-sds-dataset-id
branch of launcher which allows you to launch with thesds_dataset_id
field that is required in order to request prepop data, and attempt to open the newly addedtest_supplementary_data
survey.Using
sds_data_set_id
:34a80231-c49a-44d0-91a6-8fe1fb190e64
will return mocked supplementary data with a repeat andc067f6de-6d64-42b1-8b02-431a3486c178
will return mocked supplementary data without a repeat.Check the tests added.
Checklist