-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to launch with the sds_dataset_id #48
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll raise a separate card for it, we should dynamically select the SDS dataset id like schemas. I'll raise a card to integrate launcher with SDS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works nicely with partner runner branch👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
What is the context of this PR?
Adds the ability to launch a questionnaire schema with
sds_dataset_id
field set as Survey Metadata. This will allow us to launch surveys with Prepop data.How to review
To be tested alongside this PR: ONSdigital/eq-questionnaire-runner#1114