Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to launch with the sds_dataset_id #48

Merged
merged 5 commits into from
Jun 9, 2023
Merged

Conversation

berroar
Copy link
Contributor

@berroar berroar commented May 25, 2023

What is the context of this PR?

Adds the ability to launch a questionnaire schema with sds_dataset_id field set as Survey Metadata. This will allow us to launch surveys with Prepop data.

How to review

To be tested alongside this PR: ONSdigital/eq-questionnaire-runner#1114

@berroar
Copy link
Contributor Author

berroar commented May 25, 2023

Copy link
Contributor

@MebinAbraham MebinAbraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll raise a separate card for it, we should dynamically select the SDS dataset id like schemas. I'll raise a card to integrate launcher with SDS.

authentication/auth.go Outdated Show resolved Hide resolved
Copy link
Contributor

@kylelawsonAND kylelawsonAND left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely with partner runner branch👌

Copy link

@Yuyuutsu Yuyuutsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@berroar berroar merged commit 5c0bca7 into main Jun 9, 2023
@berroar berroar deleted the add-sds-dataset-id branch June 9, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants