Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Formatting and Linting to Launcher #70

Merged
merged 53 commits into from
Apr 15, 2024
Merged
Changes from 1 commit
Commits
Show all changes
53 commits
Select commit Hold shift + click to select a range
51e5b03
Move Javascript into external file
VirajP1002 Mar 25, 2024
f3002b9
Format static files
VirajP1002 Mar 25, 2024
4551fd7
Format template files
VirajP1002 Mar 25, 2024
564f427
Format Go file
VirajP1002 Mar 25, 2024
dca8f18
Update HTML files to pass linting
VirajP1002 Mar 27, 2024
2feca0e
Update go files to pass linting
VirajP1002 Mar 27, 2024
4526f74
Add linting to actions
VirajP1002 Mar 27, 2024
f73e68b
Update README to include makefile commands and how to install go lint…
VirajP1002 Mar 27, 2024
e374ea7
Merge branch 'main' into add-formatting-linting
VirajP1002 Mar 27, 2024
901d149
Add dependencies
VirajP1002 Mar 27, 2024
ba2d4fa
Test linting in actions
VirajP1002 Mar 27, 2024
fcb647a
Update pull_request.yml file
VirajP1002 Mar 27, 2024
60bdc32
Testing golang linter in actions
VirajP1002 Mar 27, 2024
ca66014
Update pull_request file
VirajP1002 Mar 27, 2024
e84826f
Update task name in pull_request.yaml and fix intensional mistake in …
VirajP1002 Mar 27, 2024
cf164a9
Add ESlint to Makefile command
VirajP1002 Mar 28, 2024
d415270
Add ESlint config file
VirajP1002 Mar 28, 2024
9d47131
Remove commented code
VirajP1002 Apr 2, 2024
5642a85
Refactor files
VirajP1002 Apr 3, 2024
b4d146d
fix yaml file
VirajP1002 Apr 3, 2024
5667fcf
Separate node and go from build in yaml file
VirajP1002 Apr 3, 2024
850667b
test yaml file changes
VirajP1002 Apr 3, 2024
93c6b6b
Testing actions
VirajP1002 Apr 3, 2024
755a10b
Testing changes to actions file
VirajP1002 Apr 3, 2024
aa12031
Update actions yaml file
VirajP1002 Apr 3, 2024
27fa38c
Update README
VirajP1002 Apr 3, 2024
db126eb
Change version for golangci-lint tool in actions
VirajP1002 Apr 5, 2024
15b8ad8
Intentional mistake to test new GHA changes
VirajP1002 Apr 5, 2024
3f8fee7
Revert intensional mistake
VirajP1002 Apr 5, 2024
9724fd1
Update variable names for errors and update message
VirajP1002 Apr 9, 2024
3a50cc1
Testing actions
VirajP1002 Apr 9, 2024
22d3b65
Testing actions with new ESlint config files
VirajP1002 Apr 9, 2024
c41a2a2
Testing changes to GHA
VirajP1002 Apr 9, 2024
04180e5
Revert pull_request.yaml file
VirajP1002 Apr 9, 2024
ad33700
Update actions file
VirajP1002 Apr 9, 2024
830138c
Fix missing need step
VirajP1002 Apr 9, 2024
4b24689
Remove additional install step
VirajP1002 Apr 9, 2024
b1d5e26
Revert pull_request.yaml file
VirajP1002 Apr 9, 2024
4192aca
Add scripts to package.json
VirajP1002 Apr 9, 2024
814d532
Update scripts in package.json
VirajP1002 Apr 9, 2024
5685f86
Testing actions with new eslint config file
VirajP1002 Apr 9, 2024
f163276
Testing changes to GHA actions
VirajP1002 Apr 9, 2024
faf8827
Update eslint config file
VirajP1002 Apr 9, 2024
b0e88d4
Removing config file
VirajP1002 Apr 9, 2024
18b2c44
Testing if actions works with intensional mistake
VirajP1002 Apr 9, 2024
206f6e7
Fix intensional mistake as actions worked as expected
VirajP1002 Apr 9, 2024
b2d4ee5
Install python to use djLint correctly using pipenv and remove node v…
VirajP1002 Apr 11, 2024
68ca837
Point to python version in pull_request.yaml
VirajP1002 Apr 11, 2024
6493d49
Test to try to fix actions
VirajP1002 Apr 11, 2024
5c3a604
Pin djLint and update README to add details on djLint installation
VirajP1002 Apr 11, 2024
be95b71
Move from Pipenv to Poetry and update relevant docs
VirajP1002 Apr 12, 2024
003627b
Test actions fails correctly with new changes to pull_request.yaml file
VirajP1002 Apr 12, 2024
b4c8237
Fix intensional mistake as actions worked as expected
VirajP1002 Apr 12, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert pull_request.yaml file
VirajP1002 committed Apr 9, 2024

Verified

This commit was signed with the committer’s verified signature.
VirajP1002 Viraj Patel
commit b1d5e262bf5f5804c9a6e52e618796ede46237a3
11 changes: 3 additions & 8 deletions .github/workflows/pull_request.yml
Original file line number Diff line number Diff line change
@@ -26,15 +26,7 @@ jobs:
run: go get
- name: Build
run: CGO_ENABLED=0 GOOS=linux go build -a -installsuffix cgo
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version-file: ".nvmrc"
cache: "npm"
- name: Install npm deps
run: npm install
lint:
needs: [build]
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v4
@@ -50,6 +42,9 @@ jobs:
with:
node-version-file: ".nvmrc"
cache: "npm"
- name: Install npm deps
run: npm install
- uses: actions/checkout@v3
- name: Templates linting
run: make lint-templates
- name: Static linting