Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Formatting and Linting to Launcher #70

Merged
merged 53 commits into from
Apr 15, 2024
Merged

Conversation

VirajP1002
Copy link
Contributor

@VirajP1002 VirajP1002 commented Mar 27, 2024

What is the context of this PR?

The purpose of this PR is to Implement linters and code formatters to launcher to keep our code easy to read and more consistent.

  • For Static files, the tools, ESLint & Prettier were implemented to do formatting and linting
  • For Template files, djLint was added to do formatting and linting
  • For Go files, an external tool called golangci-lint was added for linting and go fmt is used for formatting.

A Makefile was added to contain commands to format and lint files. The README was updated to include a section regarding formatting and linting where the list of Makefile commands are listed and instructions on how to add dependencies and set up the external linting tool. The pull_request.yml file was updated to ensure that linting is run as part of GHA.

How to review

  • Ensure all Make commands work
  • Ensure changes made are suitable
  • Ensure GHA changes are correct
  • Suggestions for external js file name if current is not suitable?
  • Is there a need for the .prettierignore file since it only looks for CSS and JS files?
  • Any configuration recommendations?

@VirajP1002 VirajP1002 marked this pull request as ready for review March 28, 2024 15:38
authentication/auth.go Outdated Show resolved Hide resolved
.eslintrc.json Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
.github/workflows/pull_request.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
launch.go Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
Copy link
Contributor

@berroar berroar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@VirajP1002 VirajP1002 merged commit def7aca into main Apr 15, 2024
3 checks passed
@VirajP1002 VirajP1002 deleted the add-formatting-linting branch April 15, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants