Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Returns etag in the getVersion response header #416

Merged
merged 7 commits into from
Mar 23, 2023
Merged

Returns etag in the getVersion response header #416

merged 7 commits into from
Mar 23, 2023

Conversation

vmilitaru
Copy link
Contributor

@vmilitaru vmilitaru commented Mar 22, 2023 •
edited by rafahop
Loading

What

  • returns the Etag, if set, in the response header of the getVersion request
  • refactor to avoid code duplication and use function from dp-net to set etag headers

How to review

  • check code and make sure the unit and component tests pass

Who can review

Not me nor Valentina

@rafahop rafahop mentioned this pull request Mar 23, 2023
Merged
@rafahop rafahop merged commit c8766f5 into develop Mar 23, 2023
@rafahop rafahop deleted the feature/add-etag-to-resp-header branch March 23, 2023 16:53
@rafahop rafahop mentioned this pull request Mar 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nshumoogum nshumoogum nshumoogum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vmilitaru @nshumoogum @rafahop