Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New function to read version etag #411

Merged
merged 5 commits into from
Mar 24, 2023
Merged

New function to read version etag #411

merged 5 commits into from
Mar 24, 2023

Conversation

rafahop
Copy link
Contributor

@rafahop rafahop commented Mar 23, 2023 •
edited
Loading

What

  • Add new function returning headers for Get version. Currently only containing etag
  • Add unit test for the happy path of GetVersion and for the new function GetVersionWithHeaders
  • Refactor checks of the response headers in unit test so to expand it to collection id, florence token and download service token.

How to review

Check the code and test look ok

See ONSdigital/dp-dataset-api#416 for the change in dataset api introducing the etag in the header

Who can review

Anyone.

@rafahop rafahop changed the title Add version etag New function to read version etag Mar 23, 2023
ghost
ghost previously approved these changes Mar 24, 2023
View reviewed changes
dataset/dataset_test.go Show resolved Hide resolved
@ghost ghost dismissed their stale review March 24, 2023 14:04

incorrect status

ghost
ghost suggested changes Mar 24, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see code comment

ghost
ghost approved these changes Mar 24, 2023
View reviewed changes
Copy link

@ghost ghost left a comment •
edited by ghost
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you raise a story to move the if statement on the service token test to another function pls, not needed now but nice to clean up later

@rafahop rafahop merged commit aab73f9 into main Mar 24, 2023
@rafahop rafahop deleted the feature/version-etag branch March 24, 2023 16:11
@vmilitaru vmilitaru mentioned this pull request Mar 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rafahop