Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer logo placement fix #1040

Merged
merged 1 commit into from
Sep 28, 2020
Merged

Footer logo placement fix #1040

merged 1 commit into from
Sep 28, 2020

Conversation

rmccar
Copy link
Contributor

@rmccar rmccar commented Sep 28, 2020

What is the context of this PR?

Fixes: #1039

How to review

Make sure footer logos are in correct positions.

@rmccar rmccar requested a review from trevorsaint September 28, 2020 10:00
@rmccar
Copy link
Contributor Author

rmccar commented Sep 28, 2020

@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #1040 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1040   +/-   ##
=======================================
  Coverage   93.47%   93.47%           
=======================================
  Files          34       34           
  Lines        1503     1503           
=======================================
  Hits         1405     1405           
  Misses         98       98           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 226e730...24c46f1. Read the comment docs.

@rmccar
Copy link
Contributor Author

rmccar commented Sep 28, 2020

1 similar comment
@rmccar
Copy link
Contributor Author

rmccar commented Sep 28, 2020

Copy link
Contributor

@trevorsaint trevorsaint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. All looks good.

@trevorsaint trevorsaint merged commit 599e69b into master Sep 28, 2020
@rmccar rmccar deleted the footer-logo-placement-fix branch October 2, 2020 10:53
boxadesign pushed a commit that referenced this pull request Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some footer variations not rendering correctly
2 participants