Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some footer variations not rendering correctly #1039

Closed
trevorsaint opened this issue Sep 28, 2020 · 0 comments · Fixed by #1040
Closed

Some footer variations not rendering correctly #1039

trevorsaint opened this issue Sep 28, 2020 · 0 comments · Fixed by #1040
Assignees
@rmccar
Labels
Bug Something isn't working

Comments

@trevorsaint
Copy link
Contributor

Some footer variations are not rendering correctly after merge.

As an example
image

Should be looking like this
image

This was fixed: #1009

You can preview it here: https://deploy-preview-1009--ons-design-system.netlify.app/components/footer/
@trevorsaint trevorsaint added the Bug Something isn't working label Sep 28, 2020
@rmccar rmccar mentioned this issue Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmccar rmccar

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Footer logo placement fix ONSdigital/design-system
2 participants
@trevorsaint @rmccar