Footer fix and visual enhancements #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1009 +/- ##
=======================================
Coverage 92.89% 92.89%
=======================================
Files 34 34
Lines 1507 1507
=======================================
Hits 1400 1400
Misses 107 107 Continue to review full report at Codecov.
|
rmccar
reviewed
Sep 22, 2020
…est is used or not used
trevorsaint
changed the title
This has been resolved in the update @rmccar. Time has been spent on visual enhancements and other bug fixes. @Paul-Joel spotted a visual bug when using the footer in Craft and not declaring the crest. This has been resolved.
|
rmccar
approved these changes
Sep 23, 2020
boxadesign
pushed a commit
that referenced
this pull request
Feb 17, 2023
* Changed Accessibility to Accessibility statement. Changed breakpoint to prevent bug * Various fixes for footer due to bugs. Visual enhancements when the crest is used or not used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Due to the length of the legal links a 'small' breakpoint prevented a stacked list from happening. Updating this breakpoint to medium solves the visual bug that happens.
How to review
Look at the visuals below.
Bug
Fixed
