Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote from BLAIS5-4401 to main #660

Merged
merged 21 commits into from
Nov 1, 2024
Merged

Promote from BLAIS5-4401 to main #660

merged 21 commits into from
Nov 1, 2024

Conversation

social-surveys-blaise-concourse
Copy link
Collaborator

Auto generated by concourse:

Promote from BLAIS5-4401 to main

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 73.23944% with 19 lines in your changes missing coverage. Please review.

Project coverage is 89.25%. Comparing base (ee496db) to head (304b5b5).
Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
...nnaireDetailsPage/sections/reissueNewDonorCase.tsx 0.00% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #660      +/-   ##
==========================================
- Coverage   89.78%   89.25%   -0.54%     
==========================================
  Files          76       79       +3     
  Lines        2447     2503      +56     
  Branches      295      306      +11     
==========================================
+ Hits         2197     2234      +37     
- Misses        250      269      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kristian4res kristian4res left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice one! 👍

…y to test

Adding files necessary to reissue new donor case

Changed wording and look and feel of textbox

Slight changes and fixes

Made changes to show both error messages for create donor cases and reissue new donor case

Fixing Tests so far

Fixed tests so far

Fixed issues with calling cloud function, now works correctly

Fixed failing tests

Cleaned up some code to be more generic

Added some minor fixes to try and get cloud function working on sandbox

GUI Fixes

GUI Fixes

GUI Fixes

Fixed failing test after GUI changes

Added padding around error message and various UI Fixes

Changed text input to be below text input field
…y to test

Adding files necessary to reissue new donor case

Changed wording and look and feel of textbox

Slight changes and fixes

Made changes to show both error messages for create donor cases and reissue new donor case

Fixing Tests so far

Fixed tests so far

Fixed issues with calling cloud function, now works correctly

Fixed failing tests

Cleaned up some code to be more generic

Added some minor fixes to try and get cloud function working on sandbox

GUI Fixes

GUI Fixes

GUI Fixes

Fixed failing test after GUI changes

Added padding around error message and various UI Fixes

Changed text input to be below text input field

Added padding around error message to be more inline with other components
@lambeb lambeb marked this pull request as ready for review November 1, 2024 12:39
@lambeb lambeb merged commit e3b0f29 into main Nov 1, 2024
7 checks passed
@lambeb lambeb deleted the BLAIS5-4401 branch November 1, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants