Added padding around error message and various UI Fixes

ONSdigital · Nov 1, 2024 · 59286c1 · 59286c1
1 parent 9c64f3f
commit 59286c1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/components/questionnaireDetailsPage/sections/reissueNewDonorCase.tsx b/src/components/questionnaireDetailsPage/sections/reissueNewDonorCase.tsx
@@ -33,7 +33,7 @@ function ReissueNewDonorCase({ questionnaire }: Props): ReactElement {
         <>
             <div className="ons-summary ons-u-mb-m">
                 <div className="ons-summary__group">
-                    <h2 className="ons-summary__group-title">Reissue New Donor Case for User</h2>
+                    <h2 className="ons-summary__group-title">Reissue New Donor Case</h2>
                     <table className="ons-summary__items">
                         <tbody className="ons-summary__item">
                             <tr className="ons-summary__row ons-summary__row--has-values">
@@ -45,7 +45,6 @@ function ReissueNewDonorCase({ questionnaire }: Props): ReactElement {
                                             </label>
                                             <input type="text" id="user" className="ons-input ons-input--text ons-input-type__input" value={user} onChange={(e) => setUser(e.target.value)}/>
                                         </div>
-                                        {error && <p className="ons-summary__item--error">{errorMessage}</p>}
                                     </div>
                                 </td>
                                 <td className="ons-summary__values" colSpan={2} rowSpan={2}>
@@ -57,6 +56,7 @@ function ReissueNewDonorCase({ questionnaire }: Props): ReactElement {
                                     />
                                 </td>
                             </tr>
+                            {error && <p className="ons-summary__item--error">{errorMessage}</p>}
                         </tbody>
                     </table>
                 </div>

diff --git a/src/components/reissueNewDonorCasePage/reissueNewDonorCaseSummary.test.tsx b/src/components/reissueNewDonorCasePage/reissueNewDonorCaseSummary.test.tsx
@@ -33,6 +33,6 @@ describe("ReissueNewDonorCaseSummary", () => {
         expect(
             getByText(/Error reissuing new donor case for testuser1/i)
         ).toBeInTheDocument();
-        expect(getByText(/When reporting this issue to the Service Desk, please provide the questionnaire name, user, yarn testtime and date of the failure./i)).toBeInTheDocument();
+        expect(getByText(/When reporting this issue to the Service Desk, please provide the questionnaire name, user, time and date of the failure./i)).toBeInTheDocument();
     });
 });