Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Save" doesnt save #59

Closed
zirkeltraining opened this issue May 8, 2017 · 71 comments
Closed

"Save" doesnt save #59

zirkeltraining opened this issue May 8, 2017 · 71 comments

Comments

@zirkeltraining
Copy link

When editing collaboratively in fast mode (using nextcloud), it appears the file is never written back to nextcloud until everyone ends their editing session.

Hitting the "save" button in the file menu pane does not seem to change that.
That mean that if everyone keeps all their browser tabs open, then the file never gets saved to nextcloud... until something blows up.

For example, when the file becomes no longer accessible e.g. because the sharing link timed out etc, then all of the edits can't be written back and we've lost two peoples work at once.

At other times, we've had an issue when A had shared a file with B and C, then A was temporarily locked out of the LDAP server because of a few false logins on the mail account... meanwhile B and C kept working, and didn't notice that OO now failed to save the file... boom! two days worth of data entry gone.

Can you specify how the writeback behaviour is intended to be? Why doesn't "Save" seem to save the file on Nextcloud/Owncloud?

@Taste-IT
Copy link

Hi,
same on my system with latest Nextcloud and OO-App. If i create a new file in NC und write something into this, close Tab after Document is saved, the Date in NC didnt updated. If i downloaded this file, the file doesnt have the changes. Actually i can only view existing files or write into it, but never see changes in NC. After last Update of NC i lost all Data i added in the last 4 weeks - very annoying...

@ibnpetr
Copy link

ibnpetr commented Jun 23, 2017

@Taste-IT
Hello, Could you please provide us with any information about the versions of the products installed on your server(s). We will try to reproduce the issue on our side.
Please describe your actions step by step.

After last Update of NC i lost all Data i added in the last 4 weeks - very annoying...

Have you tried to contact NC to clear the situation? If you are sure that the problem is caused by ONLYOFFICE application please provide the details. I am sure that we are able to find a solution

@Taste-IT
Copy link

I have this problem since i use OO in NC and noticed it first as i do an update of OO and all my data are gone. I have a parallel thread link i think its an handling with the cert, but dont know where the problem is, NC or OO

@thfree
Copy link

thfree commented Jun 26, 2017

Аналогичная проблема не сохраняются в файл изменения после редактирования.

nextcloud 12.0.0
onlyoffice-owncloud 1.1.2
onlyoffice-documetserver 4.3.6-2

@stuckj
Copy link

stuckj commented Nov 10, 2017

I'm seeing this as well. Pressing "save" dismisses the menu, but does nothing. I can export, however. In my case, I opened a .txt file in onlyoffice. My workaround was to simply export it in the format I wanted.

@informatico-madrid
Copy link

Hi. Same problem here. any fix yet?

@thfree
Copy link

thfree commented Dec 18, 2017

Вообще сейчас у меня все работает.
In general now everything works for me.

nextcloud 12.0.4
onlyoffice: 1.1.6
onlyoffice-documetserver 4.3.6-2

@ivanoterouvigo
Copy link

Hi all,
I had the same problem.
I wasn't able to update email of users.

Could you help me?
set_email_001

I reviewed my email, in side of spam and other but I didn't see nothing with notifications of this mail.
What I need to do?

How can I review log of mails sended? Where .. ?

ONLYOFFICE | 1.1.4
ownCloud | 0.2.2

@ghost
Copy link

ghost commented Feb 9, 2018

Same here. "Save" does not save, however closing the OnlyOffice document tab (on all browsers where it is open) does.

onlyoffice-documentserver 5.0.7-38 (Debian, not in a docker)
nextcloud 12.0.5
postgresql 10+190

@alexanderonlyoffice
Copy link

alexanderonlyoffice commented Mar 16, 2018

Hello,

@zirkeltraining, @Taste-IT, @stuckj, @hlorri, @informatico-madrid, Please do the following:
Open browser's console (tab Console and then ab Network) and click on the Save button. Please send us screenshots if there is any information about the errors.

Send us also logs of the document server and Nextcloud to [email protected] with a note "for technical support" in email.

@ivanoterouvigo, please specify if you are talking about ONLYOFFICE, as we do not have any features related with emails for integration of ONLYOFFICE and Owncloud/Nextcloud.

@e-tagirov
Copy link

is there any progress?

@alexanderonlyoffice
Copy link

@e-tagirov, we are waiting for requested information.

@e-tagirov
Copy link

@alexanderonlyoffice sent a couple of screenshots to the requested mail.

@alexanderonlyoffice
Copy link

@e-tagirov, we have received your screenshot. We will analyze them and contact you.

@dreamflasher
Copy link

Just lost 5 hours of work due to this bug. Looks like nobody is really caring about fixing data loss bugs here -.-

@thoro
Copy link

thoro commented Jan 21, 2019

Same issue here, Save button does nothing.

We have a paid Integration Edition!

@alexanderonlyoffice
Copy link

@thoro, please specify the following information about the problem:

  1. Current version of Document Server;
  2. Open browser's console (tab Console and then ab Network) and click on the Save button. Please send us screenshots if there is any information about the errors;
  3. Have you tried to clear browser cache?
  4. Send us a screenshot of ONLYOFFICE integration app address settings.

@thoro
Copy link

thoro commented Jan 21, 2019

  1. Could you tell me how to find it? The url of the document server does not provide it
  2. There's no error in the console tab, the websocket also doesn't send any values!
  3. No, but saving in general works fine I believe, just not forcing by clicking the Save button
  4. sent via email

@alexanderonlyoffice
Copy link

@thoro, we have received the screenshot and it seems that everything is fine with the address. Is there any error when clicking on the 'Save' button on ONLYOFFICE integration app address settings page?

You may find the version of Document Server, if you open any file and click on the 'About' button on the left toolbar.

Please note that if you enabled force save feature in Document Server, it is not working in integration with Nextcloud. If this is not the issue you mentioned, please describe the scenario of how it can be reproduced.

@thoro
Copy link

thoro commented Jan 21, 2019

@alexanderonlyoffice Ha, hard to find, currently it's 5.1.5

As far as I can see int he configs the force save feature is not activated.

Btw. is the plugin locking the file to stop people from overwriting the original via Desktop Sync?

@alexanderonlyoffice
Copy link

@thoro, could you please describe the issue you have more precisely, with screenshots or video if possible.

Btw. is the plugin locking the file to stop people from overwriting the original via Desktop Sync?

There is no possibility to lock the files. If users have access permissions to the file in Nextcloud account, they will have the same permissions in Desktop Editors.

@thoro
Copy link

thoro commented Jan 21, 2019

I thought that when you click the save button that OnlyOffice will save the file as it currently is back to nextcloud. When clicking the button nothing happens, the menu closes, but there is no webrequest, or websocket data.

  1. I mean, if people have the Nextcloud Desktop application, and they open the file in Excel, and therefore edit a old file which is not shared with anyone, and then save it to Nextcloud, they overwrite all the progress from the online editor, it would be good if in this case the file would be saves as a version and not overwrite the onlyoffice data.

@alexanderonlyoffice
Copy link

@thoro,

  1. When you click on the 'Save' icon in editor changes made to the file are sent to the Document Server, but the new version of the file will be built only when the tab with editor is closed in browser (when the editing session is over).

  2. Please check if the Versions application is enabled in Nextcloud.

@thoro
Copy link

thoro commented Jan 22, 2019

Oh!

  1. is there an option to actually force from the client side a save back to nextcloud? As others said it happens constantly that the files stay open in some background tab

  2. Versions is activated

@alexanderonlyoffice
Copy link

@thoro,

is there an option to actually force from the client side a save back to nextcloud?

This is exactly force saving, which is not working in integration with Nextcloud due to some technical limitations, which cannot be solved at the moment.

I mean, if people have the Nextcloud Desktop application, and they open the file in Excel, and therefore edit a old file which is not shared with anyone, and then save it to Nextcloud, they overwrite all the progress from the online editor, it would be good if in this case the file would be saves as a version and not overwrite the onlyoffice data.

We will check this case.

@KuenzelIT
Copy link

is there an option to actually force from the client side a save back to nextcloud?

This is exactly force saving, which is not working in integration with Nextcloud due to some technical limitations, which cannot be solved at the moment.

So the owncloud integration can save back to the owncloud when all tabs are closed but not forced by some client action? This would be a really important feature.

The 'Save' button does not do anything at our instance, there is nothing on the console or in the network tab of the dev tools.

@alexanderonlyoffice
Copy link

@KuenzelIT,

So the owncloud integration can save back to the owncloud when all tabs are closed but not forced by some client action? This would be a really important feature.

Thank you for your feedback. As it was mentioned before there are some technical issues preventing us from implementing this feature. We are working on it.

The 'Save' button does not do anything at our instance, there is nothing on the console or in the network tab of the dev tools.

When you click on the 'Save' icon in editor changes made to the file are sent to the Document Server, but the new version of the file will be built only when the tab with editor is closed in browser (when the editing session is over).

@msumm
Copy link

msumm commented Aug 20, 2019

As pointed out here the problem might be hot-fixed by disabling the Versions App (in particular when the files to edit are located on an external storage).

@pricard32
Copy link

Any progress on this? I've lost some important data... it seems to be long time since this tread are open...

@KuenzelIT
Copy link

@KuenzelIT Did you got a reply? I also can not understand why this this so hard to solve. I don't have the time to dig into the code, but i assume it could be a one-liner.

Unfortunately not.

@LAU10BAX
Copy link

LAU10BAX commented Apr 3, 2020

We have same issue by using the integrated application "$HOST/index.php/apps/documentserver_community/" This problem becomes nowadays more urgent, because of Corona so many more colleagues are forced to work from Home and we need to share some files safely, privately and within the browser.

Our System:

  • Ubuntu LTS 18.04
  • Nextcloud 18.0.3
  • OnlyOffice 4.1.4

We've tried cronjobs, putting down session time of users and many more. We appreciate any help!

@philipp1992
Copy link

we are also affected by this bug, exactly the same behaviour. @alexanderonlyoffice please keep us updated

@ghost
Copy link

ghost commented Jun 25, 2020

We have integrated Nextcloud and OnlyOffice into our online platform. The problem that all tabs of all users of a document have to be closed first is a huge problem for us. We would be so grateful if there could be a solution for a regular forced save. Who can we turn to to solve the problem? Can you tell us what the problem is that for years the problem has not been solved? Perhaps we could also work together.

@alexanderonlyoffice @LinneyS

@sinni800
Copy link

sinni800 commented Jun 25, 2020

https://api.onlyoffice.com/editors/save

I've checked out this page of the API of OnlyOffice and there are a few interesting infos relating to this topic:

First of all, apparently automatic saving (back to the document storage) should happen within 10 seconds after editing has concluded. It doesn't define what that means, so I can't say if they mean "after the file was closed out" or something else.

Second, there is a "force saving" mode where one can either force save by a request to the document server (triggering the save callback to the document storage, nextcloud/owncloud in our case, instantly), or the force save will be triggered 5 minutes (by default?) after (guessing here) nothing happened on the document anymore.

I'm almost guessing the force save is executed on the timeout for some reason, except the regular automatic saving. I don't have enough insight into the code here to even say how the regular saving would be triggered (hitting "save" apparently only saves to the document server)... I've tried to investigate it for a bit and haven't been coming up with anything good.

But there's an option that would attach the "save" button in the document to the "force save" function. Quoting from the page above:

Enable the editorConfig.customization.forcesave mode setting it to true in the editor initialization configuration. In this case each time the user clicks the Save button, the forcesave will be done, and the forcesavetype parameter will have the 1 value when sending the request to the callback handler.

This could be configurable using the config gui in the nextcloud configuration for the onlyoffice app, the editor configs are applied here: https://github.com/ONLYOFFICE/onlyoffice-owncloud/blob/master/controller/editorcontroller.php#L847

$params["editorConfig"]["customization"]["forcesave"] = true;

In fact, putting this line into the function at line 847 into editorcontroller.php should already enable force saving by hitting the save button.

EDIT: It did change the save button to have a little circle thingy on it, so I suppose it was enabled by that.

But hitting that save button does nothing for me. Can anyone else try it too?

@grueneedv
Copy link

We have the same problem here. We have OnlyOffice Version 5.6.0, running within the docker solution "onlyoffice/documentserver-ie latest".
Already edited the /etc/onlyoffice/documentserver/local.json and added "autoAssembly": { "enable": true, "interval": "5m" } as suggested here https://api.onlyoffice.com/editors/save and did a /usr/bin/documentserver-generate-allfonts.sh to trigger a restart within the docker container. No Help.
Tried the cron solution, so did a crontab -u www-data -e adding */5 * * * * php -f /var/www/html/nextcloud/cron.php and changed in admin settings from nextcloud the cron managment from AJAX to cron. No Help.
Looked in the Browser Network analytics everything is fine:
Save Problem

So where to look next?

@mhl66
Copy link

mhl66 commented Aug 2, 2020

Since 2017, this bug exists, and it makes OnlyOffice UNUSABLE as a plugin for NextCloud. Anyone disagrees?

@ghost
Copy link

ghost commented Aug 2, 2020

I heard that the bug was fixed with the last update. But we haven't been able to test it yet, because we integrated Nextcloud with OnlyOffice into an online platform and with the update the structure has changed as well, so we can only program the link properly again.

Has anyone tested the latest update to see if the bug is really fixed?

@mhl66 @grueneedv @sinni800 @philipp1992 @alexanderonlyoffice

@mhl66
Copy link

mhl66 commented Aug 2, 2020

In case you´re referring to the last update of Nextcloud (18.0.7): same year-old bug. The last version of OnlyOffice in this version is displayed as 4.3.0.

@grueneedv
Copy link

We're currently using

  • Nextcloud 18.0.3
  • 4.3.0 Plugin of OnlyOffice
  • 5.6.0 as OnlyOffice Version (within docker document-ie version).

This setup didn't worked on friday, but today after I restartet the nextcloud and the onlyoffice server completly. Will investigate further when saving files doesn't work again.

@mhl66
Copy link

mhl66 commented Aug 3, 2020

Clarification: Using Nextcloud 18.0.7 (=latest production version), 4.3.0 Plugin of OnlyOffice (latest) and Community Document Server of OnlyOffice, Version 0.1.7

INACCEPTABLE PROBLEM! Data lost! See nextcloud/documentserver_community#12

@gcommit
Copy link

gcommit commented Sep 7, 2020

We have the same problem ....
NC version 19.0.2

can anyone help? I mean, we used collabora for years without bigger issues and swiched to OnlyOffice since it was build in to Nextcloud Hub and now changes are not written to file, so downloaded files are empty and the save button can't be used.
Bildschirmfoto 2020-09-07 um 14 58 36

@LinneyS
Copy link
Member

LinneyS commented Sep 29, 2020

Hi all!
Try Keep intermediate versions when editing in settings in v6.0.1

@LinneyS LinneyS closed this as completed Sep 29, 2020
@mhl66
Copy link

mhl66 commented Sep 30, 2020

Hi all!
Try Keep intermediate versions when editing in settings in v6.0.1

Very funny - the newest version is 6.0.0 here.

The issue is still the same since 2017. Time to fix it.

@sinni800
Copy link

I looked into the current code and the solution applied here is the same that I detailed in #59 (comment), but I concluded that it didn't work for me... Does this change work for anyone else?

@mhl66
Copy link

mhl66 commented Sep 30, 2020

To clarify: KEEP INTERMEDIATE VERSIONS WHEN EDITING (= "ZWISCHENVERSIONEN BEI DER BEARBEITUNG AUFBEWAHREN") does not change anything, it still does not "force save".

An office suite without saving?

@sinni800
Copy link

I think the option is even weirdly named for what it does (enable force save)

@mhl66
Copy link

mhl66 commented Sep 30, 2020

Yeah, and the german translation is even more ridiculous. But anyway, IT DOES NOT WORK!

@4001982248998
Copy link

It seems to work for me, at least!

@philipp1992
Copy link

Does not work for me. Fresh installation.

@ibnpetr
Copy link

ibnpetr commented Sep 30, 2020

An office suite without saving?

Could you please contact us at [email protected] (subject "OC saving issue") and we will analyze the issue.
We will need a temporary access to your environment.

@mhl66
Copy link

mhl66 commented Sep 30, 2020

You´re kidding? "we will analyze the issue" is hardly appropriate, if you kindly read this thread from 2017 on.

Moreover, it´s sure to border on insolence to close this thread, referring to a version that is not even available for Nextcloud (6.0.1) by @LinneyS .

@ibnpetr
Copy link

ibnpetr commented Sep 30, 2020

You´re kidding? "we will analyze the issue" is hardly appropriate, if you kindly read this thread from 2017 on.

Moreover, it´s sure to border on insolence to close this thread, referring to a version that is not even available for Nextcloud (6.0.1) by @LinneyS .

Don't you mind if I ask you again to send us access to your environment.
Looking forward to hearing from you.

@LinneyS
Copy link
Member

LinneyS commented Sep 30, 2020

@mhl66

Very funny

Have you messed up the repository?

@mhl66
Copy link

mhl66 commented Sep 30, 2020

Indeed, the 6.0.0 is the newest version on https://github.com/ONLYOFFICE/onlyoffice-nextcloud. That´s what I was referring to. Please excuse the inappropriate comment "very funny". Nevertheless, it obviously (see issue section) does not work on both worlds - OWNCLOUD AND NEXTCLOUD for those users (probably the majority) using the document server module.

@LinneyS
Copy link
Member

LinneyS commented Oct 1, 2020

@mhl66
The analysis showed that Community Document Server does not work with forcesave.

Please note that Community Document Server was developed by Nextcloud Team, if you have any issues with it, please contact them in the appropriate GitHub repository.

If you are using our official method of integration (Nextcloud + dedicated Document Server instance as per our installation guide), we will be glad to answer your questions. Please see more info on our forum.

@KuenzelIT
Copy link

Hi all!
Try Keep intermediate versions when editing in settings in v6.0.1

This was quite confusing since there is no version v6.0.1. You probably mean v6.0.0: changelog

@LinneyS
Copy link
Member

LinneyS commented Oct 2, 2020

@KuenzelIT
Have you messed up the repository?

@KuenzelIT
Copy link

@KuenzelIT
Have you messed up the repository?

Seems like it. I just now noticed the owncloud/nextcloud difference in the repository name. I assume my brain already processes those words as being the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests