This repository has been archived by the owner on Jan 5, 2022. It is now read-only.
Add validation for Display Id format #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sgtpluck
commented
Nov 10, 2021
| @@ -38,6 +39,7 @@ def api_error_message | |||
| private | |||
|
|
|||
| def api_call_succeeded | |||
| return unless errors.blank? | |||
There was a problem hiding this comment.
this way, the API call won't happen if the display id is the wrong format
jduss4
approved these changes
Nov 15, 2021
| @@ -57,6 +59,12 @@ def api | |||
| ApiDelegator.use("tta", "activity_report", display_id: display_id, access_token: access_token) | |||
| end | |||
|
|
|||
| def check_display_id_format | |||
| unless display_id.match?(/^R\d{2}-AR-/) | |||
There was a problem hiding this comment.
[comment, non-blocking] I can't find where I've seen the legacy display id format, but I think this regex will only work for the current format. I think it's good enough for our current purposes, though. Do you think it's worth adding a comment in case anybody is working from our code?
Sgtpluck
force-pushed
the
dmm/add-tta-link-validation
branch
from
7b55b59 to
be38a62
Compare
Sgtpluck
force-pushed
the
dmm/add-tta-link-validation
branch
from
be38a62 to
b7e8795
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Adds some validation around the TTA Display ID format because TTAHub 500s if the display id is not in the expected format.
Acceptance Criteria
When I input a TTA Activity Report Display ID that does not match the format
/^R/d{2}-AR-/I want an error that tells me it's a bad format
So I know what the problem is
How to test
/^R/d{2}-AR-/formatChecklist
To be completed by the submitter:
To the Reviewer
This project is using Conventional Comments to give structure
and context to PR comments. Please use these labels in your comments.