-
-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] storage_image_product: Migration to 18.0 #437
base: 18.0
Are you sure you want to change the base?
Conversation
… drop some essential feature of kanban, like ordering the kanban based on the sequence...
… add security access
…r, remove needed of module quick create
…site_sale is installed (this standard module have a same model) Update security
It can be confusing to not be able to edit images from the variants, this texts helps to get how to do it (from the template)
…_relation) to allow delete
Add a default value for the field 'Apply On', on image tags when creating them on the fly from category.image.relation or product.image.relation. The default value is 'product' when coming from product.image.relation and 'category' when coming from category.image.relation. Still no default value is provided when there's no active model matching one of these two in the context.
…form to avoid js erreor
…g with available product attributes
8ffb902
to
b6783d2
Compare
b6783d2
to
96b62a6
Compare
/ocabot migration storage_image_product |
@@ -31,13 +31,11 @@ def _get_default_apply_on(self): | |||
comodel_name="product.image.relation", | |||
inverse_name="tag_id", | |||
string="Product Image Relations", | |||
readonly=True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we removing these readonly attributes?
(same for categ_img_rel_ids
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reason: If a field is marked as readonly=True on the model, it won't be possible to import it through the Odoo import tool, so avoid it as possible and define the readonly attribute on the views instead.
Document: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0
Depends on: