[18.0][MIG] storage_file: Migration to 18.0 #434

thienvh332 · 2024-11-29T09:32:45Z

No description provided.

StefanRijnhart

Thanks!

storage_file/models/storage_file.py

StefanRijnhart · 2024-12-04T15:09:46Z

Maybe squash 'Raph's commits into one big [WIP] storage_file commit

storage_file/models/storage_backend.py

storage_file/models/storage_file.py

StefanRijnhart

Thanks for the updates!

ivantodorovich · 2025-01-06T16:29:07Z

storage_file/models/storage_file.py

+                if record.data:
+                    raise UserError(
+                        self.env._(
+                            "File can not be updated," "remove it and create a new one"


Suggested change

"File can not be updated," "remove it and create a new one"

"File can not be updated, remove it and create a new one"

ivantodorovich · 2025-01-06T16:30:26Z

storage_file/models/storage_file.py

+    def _clean_storage_file(self):
+        # we must be sure that all the changes are into the DB since
+        # we by pass the ORM
+        self.env.flush_all()


Suggested change

self.env.flush_all()

self.flush_model(["to_delete"])

nitpicking: this is actually more accurate

ivantodorovich · 2025-01-06T16:31:51Z

storage_file/tests/test_storage_file.py

-            self.env[storage_file._name].with_user(public_user).browse(
-                storage_file.ids
-            ).name
+            _ = (


Why are you assigning to _ ?

This is why I declared the variable unused for it: B018 Found useless attribute access. Either assign it to a variable or remove it.

Oh, if it's just a linter rule, you can disable it it with an inline comment.
E.g.:

self.env[storage_file._name].with_user(public_user).browse(storage_file.ids).name # noqa: B018

Thanks you, It doesn't work because it crossed the line when combined with pre-commit with max characters being 88 per line

@thienvh332 Can you at least assign the value to a string starting with _ to avoid the warning but not to the character _ alone to avoid the confusion with the translation method _.

storage_file/models/storage_backend.py

OCA-git-bot · 2025-01-06T16:38:47Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

storage_file/models/storage_file.py

ivantodorovich · 2025-01-07T11:50:39Z

storage_file/tests/test_storage_file.py

-            self.env[storage_file._name].with_user(public_user).browse(
-                storage_file.ids
-            ).name
+            _ = (


Oh, if it's just a linter rule, you can disable it it with an inline comment.
E.g.:

self.env[storage_file._name].with_user(public_user).browse(storage_file.ids).name # noqa: B018

storage_file/models/storage_file.py

lmignon

Thank you for the migration. A little comment....

lmignon · 2025-01-30T10:27:50Z

storage_file/tests/test_storage_file.py

-            self.env[storage_file._name].with_user(public_user).browse(
-                storage_file.ids
-            ).name
+            _ = (


@thienvh332 Can you at least assign the value to a string starting with _ to avoid the warning but not to the character _ alone to avoid the confusion with the translation method _.

lmignon · 2025-01-30T13:04:21Z

/ocabot migrate storage_file

OCA-git-bot · 2025-01-30T13:04:24Z

Hi @lmignon. Your command failed:

Invalid command: migrate.

Ocabot commands

ocabot merge major|minor|patch|nobump
ocabot rebase
ocabot migration {MODULE_NAME}

More information

ocabot documentation
OCA guidelines, specially the "Version Numbers" section.

lmignon · 2025-01-30T13:04:45Z

/ocabot migration storage_file

In some cases, is desirable to not have the CDN URL. Examples: - reduce payload of images metadata (URL is the same for all of them) - use same storage but different CDN URLs for different frontends

Copy will only work when using name_id strategy, when using checksum, it will fail, as the relative_path must be unique by storage

simahawk · 2025-02-10T07:19:46Z

/ocabot merge nobump

comment attended

simahawk · 2025-02-10T09:05:54Z

/ocabot merge nobump

OCA-git-bot · 2025-02-10T09:06:00Z

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-434-by-simahawk-bump-nobump, awaiting test results.

OCA-git-bot · 2025-02-10T09:09:43Z

Congratulations, your PR was merged at 9f65f0c. Thanks a lot for contributing to OCA. ❤️

This was referenced Nov 29, 2024

[18.0][MIG] storage_thumbnail: Migration to 18.0 #435

Open

[18.0][MIG] storage_image: Migration to 18.0 #436

Open

[18.0][MIG] storage_image_product: Migration to 18.0 #437

Open

thienvh332 marked this pull request as ready for review November 29, 2024 09:52

StefanRijnhart reviewed Dec 4, 2024

View reviewed changes

storage_file/models/storage_file.py Show resolved Hide resolved

thienvh332 force-pushed the 18.0-mig-storage_file_temp branch from f16bdd7 to bfa8518 Compare December 5, 2024 03:01

thienvh332 requested a review from StefanRijnhart December 5, 2024 03:10

StefanRijnhart reviewed Dec 5, 2024

View reviewed changes

storage_file/models/storage_backend.py Outdated Show resolved Hide resolved

storage_file/models/storage_file.py Show resolved Hide resolved

thienvh332 force-pushed the 18.0-mig-storage_file_temp branch from bfa8518 to 5dc012d Compare December 6, 2024 02:57

StefanRijnhart approved these changes Dec 6, 2024

View reviewed changes

thienvh332 mentioned this pull request Jan 6, 2025

[18.0][MIG] storage_media: Migration to 18.0 #438

Open

ivantodorovich approved these changes Jan 6, 2025

View reviewed changes

OCA-git-bot added approved ready to merge labels Jan 6, 2025

ivantodorovich reviewed Jan 6, 2025

View reviewed changes

storage_file/models/storage_file.py Show resolved Hide resolved

thienvh332 force-pushed the 18.0-mig-storage_file_temp branch from 5dc012d to 002bf64 Compare January 7, 2025 03:41

ivantodorovich approved these changes Jan 7, 2025

View reviewed changes

thienvh332 force-pushed the 18.0-mig-storage_file_temp branch 2 times, most recently from c1aaba9 to f8a649e Compare January 8, 2025 03:23

lmignon previously requested changes Jan 30, 2025

View reviewed changes

OCA-git-bot removed approved ready to merge labels Jan 30, 2025

OCA-git-bot added this to the 18.0 milestone Jan 30, 2025

OCA-git-bot mentioned this pull request Jan 30, 2025

Migration to version 18.0 #398

Open

21 tasks

[IMP] add meta code

6bbb7cc

OCA-git-bot and others added 16 commits February 4, 2025 09:33

storage_file 14.0.2.1.2

d0ed51c

[IMP] update dotfiles [ci skip]

b1d585e

storage_file: add internal_url

fa8de2b

storage_file: add flag to control internal_url usage

53f61f4

[UPD] Update storage_file.pot

a9bffd5

storage_file 14.0.2.2.0

20c38f8

[MIG] storage_file: Migration to 15.0

0835c96

[UPD] Update storage_file.pot

df3bdea

[UPD] README.rst

77d98b1

[UPD] README.rst

ca84691

[IMP] storage_file: pre-commit auto fixes

bea64cd

storage_file: add url_path (no CDN URL)

de30737

In some cases, is desirable to not have the CDN URL. Examples: - reduce payload of images metadata (URL is the same for all of them) - use same storage but different CDN URLs for different frontends

[FIX] storage_file: fix copy

e29d2be

Copy will only work when using name_id strategy, when using checksum, it will fail, as the relative_path must be unique by storage

storage_file: Add wizard template to update files

e93c2e1

oca-port: blacklist PR(s) , 78, 106, 298 for storage_file

4c9ab50

[MIG] storage_file: Migration to 18.0

c3efaf7

thienvh332 force-pushed the 18.0-mig-storage_file_temp branch from f8a649e to c3efaf7 Compare February 4, 2025 02:34

thienvh332 requested a review from lmignon February 4, 2025 02:37

simahawk approved these changes Feb 10, 2025

View reviewed changes

OCA-git-bot added the approved label Feb 10, 2025

OCA-git-bot added the bot is merging ⏳ label Feb 10, 2025

OCA-git-bot merged commit b86528b into OCA:18.0 Feb 10, 2025
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Feb 10, 2025

LucasTran380381 mentioned this pull request Feb 17, 2025

[18.0][MIG] storage_media_product: Migration to 18.0 #441

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[18.0][MIG] storage_file: Migration to 18.0 #434

[18.0][MIG] storage_file: Migration to 18.0 #434

thienvh332 commented Nov 29, 2024

StefanRijnhart left a comment

StefanRijnhart commented Dec 4, 2024

StefanRijnhart left a comment

ivantodorovich Jan 6, 2025

ivantodorovich Jan 6, 2025

ivantodorovich Jan 6, 2025

thienvh332 Jan 7, 2025

ivantodorovich Jan 7, 2025

thienvh332 Jan 8, 2025

lmignon Jan 30, 2025 •

edited

Loading

OCA-git-bot commented Jan 6, 2025

ivantodorovich Jan 7, 2025

lmignon left a comment

lmignon Jan 30, 2025 •

edited

Loading

lmignon commented Jan 30, 2025

OCA-git-bot commented Jan 30, 2025

lmignon commented Jan 30, 2025

simahawk commented Feb 10, 2025

simahawk commented Feb 10, 2025

OCA-git-bot commented Feb 10, 2025

OCA-git-bot commented Feb 10, 2025

	"File can not be updated," "remove it and create a new one"
	"File can not be updated, remove it and create a new one"

[18.0][MIG] storage_file: Migration to 18.0 #434

[18.0][MIG] storage_file: Migration to 18.0 #434

Conversation

thienvh332 commented Nov 29, 2024

StefanRijnhart left a comment

Choose a reason for hiding this comment

StefanRijnhart commented Dec 4, 2024

StefanRijnhart left a comment

Choose a reason for hiding this comment

ivantodorovich Jan 6, 2025

Choose a reason for hiding this comment

ivantodorovich Jan 6, 2025

Choose a reason for hiding this comment

ivantodorovich Jan 6, 2025

Choose a reason for hiding this comment

thienvh332 Jan 7, 2025

Choose a reason for hiding this comment

ivantodorovich Jan 7, 2025

Choose a reason for hiding this comment

thienvh332 Jan 8, 2025

Choose a reason for hiding this comment

lmignon Jan 30, 2025 • edited Loading

Choose a reason for hiding this comment

OCA-git-bot commented Jan 6, 2025

ivantodorovich Jan 7, 2025

Choose a reason for hiding this comment

lmignon left a comment

Choose a reason for hiding this comment

lmignon Jan 30, 2025 • edited Loading

Choose a reason for hiding this comment

lmignon commented Jan 30, 2025

OCA-git-bot commented Jan 30, 2025

lmignon commented Jan 30, 2025

simahawk commented Feb 10, 2025

simahawk commented Feb 10, 2025

OCA-git-bot commented Feb 10, 2025

OCA-git-bot commented Feb 10, 2025

lmignon Jan 30, 2025 •

edited

Loading

lmignon Jan 30, 2025 •

edited

Loading