[13.0][FIX] storage media listed on product variant #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes the media displayed on the product variant form in the media tab. The change on the depends force the recomputation when an attibute value is changed on the product.media.relation. The other change fixes the attributes value that are tested to assign a media on a variant. It is the attribute set on the product variant that should be used and not all attribute values assigned to the product template.
|
Hi @TDu! Thank you very much for this contribution. As the addon you are improving does not have a declared maintainer, I take the opportunity to mention that you can consider adopting it. To do so, please read the maintainer role description, and, if interested, create a pull request to add your GitHub login to the |
mmequignon
approved these changes
Sep 6, 2021
simahawk
approved these changes
Sep 6, 2021
sebalix
approved these changes
Sep 6, 2021
|
/ocabot merge patch @TDu would you mind porting this to v14? |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 8a21b2f. Thanks a lot for contributing to OCA. ❤️ |
TDu
added a commit
to camptocamp/storage
that referenced
this pull request
Sep 9, 2021
This PR fixes the media displayed on the product variant form in the media tab. The change on the depends force the recomputation when an attibute value is changed on the product.media.relation. The other change fixes the attributes value that are tested to assign a media on a variant. It is the attribute set on the product variant that should be used and not all attribute values assigned to the product template. This is a forward port from: * OCA#116
TDu
added a commit
to camptocamp/storage
that referenced
this pull request
Sep 9, 2021
This PR fixes the media displayed on the product variant form in the media tab. The change on the depends force the recomputation when an attibute value is changed on the product.media.relation. The other change fixes the attributes value that are tested to assign a media on a variant. It is the attribute set on the product variant that should be used and not all attribute values assigned to the product template. Forward port from: * OCA#116
JasminSForgeFlow
pushed a commit
to ForgeFlow/storage
that referenced
this pull request
Oct 26, 2023
This PR fixes the media displayed on the product variant form in the media tab. The change on the depends force the recomputation when an attibute value is changed on the product.media.relation. The other change fixes the attributes value that are tested to assign a media on a variant. It is the attribute set on the product variant that should be used and not all attribute values assigned to the product template. Forward port from: * OCA#116
LucasTran380381
pushed a commit
to LucasTran380381/storage
that referenced
this pull request
Jan 7, 2025
This PR fixes the media displayed on the product variant form in the media tab. The change on the depends force the recomputation when an attibute value is changed on the product.media.relation. The other change fixes the attributes value that are tested to assign a media on a variant. It is the attribute set on the product variant that should be used and not all attribute values assigned to the product template. Forward port from: * OCA#116
sebalix
pushed a commit
to camptocamp/storage
that referenced
this pull request
Jan 22, 2025
This PR fixes the media displayed on the product variant form in the media tab. The change on the depends force the recomputation when an attibute value is changed on the product.media.relation. The other change fixes the attributes value that are tested to assign a media on a variant. It is the attribute set on the product variant that should be used and not all attribute values assigned to the product template. Forward port from: * OCA#116
sebalix
pushed a commit
to camptocamp/storage
that referenced
this pull request
Feb 20, 2025
This PR fixes the media displayed on the product variant form in the media tab. The change on the depends force the recomputation when an attibute value is changed on the product.media.relation. The other change fixes the attributes value that are tested to assign a media on a variant. It is the attribute set on the product variant that should be used and not all attribute values assigned to the product template. Forward port from: * OCA#116
sebalix
pushed a commit
to camptocamp/storage
that referenced
this pull request
Mar 4, 2025
This PR fixes the media displayed on the product variant form in the media tab. The change on the depends force the recomputation when an attibute value is changed on the product.media.relation. The other change fixes the attributes value that are tested to assign a media on a variant. It is the attribute set on the product variant that should be used and not all attribute values assigned to the product template. Forward port from: * OCA#116
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the media displayed on the product variant form in the media
tab.
The change on the depends force the recomputation when an attibute value
is changed on the product.media.relation.
The other change fixes the attributes value that are tested to assign
a media on a variant.
It is the attribute set on the product variant that should be used and
not all attribute values assigned to the product template.