[13.0][IMP]storage_image_product: main image of the variant

[AaronHForgeFlow]

@ForgeFlow @HviorForgeFlow

[OCA-git-bot]

Hi @AaronHForgeFlow! Thank you very much for this contribution. As the addon you are improving does not have a declared maintainer, I take the opportunity to mention that you can consider adopting it. To do so, please read the maintainer role description, and, if interested, create a pull request to add your GitHub login to the maintainers key of the addon manifest.

[simahawk]

this is similar to #116 but for images right?

[AaronHForgeFlow]

When the images are attached to the template and not to the variant. In that case in the variant it shows an image without attributes. The fix search first for images with the same attributes than the variant.

Perhaps this is not a common use case as long I am storing all the images in the template instead of storing them in any image individually. If that is the case I will close this.

[sebastienbeau]

Hi
I think I understand.
If you put 3 images on a product template in this order

• a generic image for all product (like a image of the situtation, or an image with all the variant visible)
• a specific image for the blue product
• a specific image for the red product

With the existing implementation, the generic one will used as main image for the product template and for all variant.
With your change each variant will try to show the first "specific image" that match for them. So in our case it will a be the blue image for the blue product, the red image for the red product.

I am correct ?

If yes it's seem to be a good idea, can you add a test? If needed i can do it

Thanks

[AaronHForgeFlow]

If you put 3 images on a product template in this order

a generic image for all product (like a image of the situtation, or an image with all the variant visible)
a specific image for the blue product
a specific image for the red product
With the existing implementation, the generic one will used as main image for the product template and for all variant.
With your change each variant will try to show the first "specific image" that match for them. So in our case it will a be the blue image for the blue product, the red image for the red product.

Yes, exactly :)

I will try to add a test Thanks for the review!

[AaronHForgeFlow]

Test added :)

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[sebastienbeau]

@AaronHForgeFlow can you add the change propose by alex ? so we can merge this ? Thansk

[AaronHForgeFlow]

@AaronHForgeFlow can you add the change propose by alex ? so we can merge this ? Thansk

Done! Thanks! :)

[sebastienbeau]

/ocabot merge major

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-115-by-sebastienbeau-bump-major, awaiting test results.

[sebastienbeau]

Thanks @AaronHForgeFlow for your work !

[OCA-git-bot]

Congratulations, your PR was merged at b228589. Thanks a lot for contributing to OCA. ❤️