Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] stock_restrict_lot #1652

Merged
merged 28 commits into from
Aug 7, 2024
Merged

[17.0][MIG] stock_restrict_lot #1652

merged 28 commits into from
Aug 7, 2024

Conversation

jcadhoc
Copy link

@jcadhoc jcadhoc commented Jul 10, 2024

No description provided.

florian-dacosta and others added 27 commits July 10, 2024 11:16
@florian-dacosta @jcadhoc
Add module stock_restrict_lot
266ae61
@florian-dacosta @jcadhoc
Avoid copying restrict_lot_id field on stock move unless it is a split
a74c45e
@oca-travis @jcadhoc
[UPD] Update stock_restrict_lot.pot
8cf3a3f
@OCA-git-bot @jcadhoc
[UPD] README.rst
305d311
@OCA-git-bot @jcadhoc
[ADD] icon.png
6b5e80a
@newtratip @jcadhoc
[14.0][FIX] stock_restrict_lot
1d7898a
@OCA-git-bot @jcadhoc
stock_restrict_lot 14.0.1.1.1
a94139a
@florian-dacosta @jcadhoc
Add module stock_restrict_lot
f4818e2
@florian-dacosta @jcadhoc
Avoid copying restrict_lot_id field on stock move unless it is a split
14fce1f
@newtratip @jcadhoc
[14.0][FIX] stock_restrict_lot
67957c7 
stock_restrict_lot 14.0.1.1.1
@bizzappdev @jcadhoc
[IMP]stock_restrict_lot: migrate stock_restrict_lot module
90edc31 
[UPD] Update stock_restrict_lot.pot

[UPD] README.rst
@petrus-v @jcadhoc
[FIX] stock_restrict_lot: do not merge stock move with different rest…
b51b964 
…rict_lot_id

Odoo tries to avoid extra stock.move while generating stock.picking from
pull/push rules. We must tell odoo to not merge stock.move if they are restricted
different lot.

To reproduce this behaviour using sale_order_lot_selection you have to:
* setup inventory with multi-step routes
* setup warehouse with two steps outgoing shipments
* receive products with different lot
* create a sale order with different quantities per lot
* validate the sale order

Before this PR stock.move in the internal stock.picking pick order are merged

After this PR we have one line per selected lot in internal stock.picking pick order

stock_restrict_lot 15.0.0.0.2
@florian-dacosta @jcadhoc
[MIG] Migrate stock_restrict_lot to v16
3b0b944
@jcadhoc
[UPD] Update stock_restrict_lot.pot
3b3d63f
@OCA-git-bot @jcadhoc
[UPD] README.rst
70892c6
@florian-dacosta @jcadhoc
[IMP][stock_restrict_lot] Add lot in move list views
5070105
@jcadhoc
[UPD] Update stock_restrict_lot.pot
9f582d3
@OCA-git-bot @jcadhoc
stock_restrict_lot 16.0.1.1.0
9f84eef
@badbole @jcadhoc
Added translation using Weblate (Croatian)
4056daf
@badbole @jcadhoc
Translated using Weblate (Croatian)
78955b4 
Currently translated at 100.0% (6 of 6 strings)

Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_restrict_lot
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_restrict_lot/hr/
@OCA-git-bot @jcadhoc
[UPD] README.rst
6f9d06d
@weblate @jcadhoc
Update translation files
ebbe412 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_restrict_lot
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_restrict_lot/
@mymage @jcadhoc
Added translation using Weblate (Italian)
b4abd3a
@mymage @jcadhoc
Translated using Weblate (Italian)
93e3bfd 
Currently translated at 100.0% (6 of 6 strings)

Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_restrict_lot
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_restrict_lot/it/
@Ivorra78 @jcadhoc
Added translation using Weblate (Spanish)
2b4b23e
@Ivorra78 @jcadhoc
Translated using Weblate (Spanish)
66de21d 
Currently translated at 100.0% (6 of 6 strings)

Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_restrict_lot
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_restrict_lot/es/
@jcadhoc
[IMP] stock_restrict_lot: pre-commit auto fixes
bb2cd8a
@jcadhoc jcadhoc force-pushed the 17.0-mig-stock_restrict_lot branch 2 times, most recently from 2dcb131 to c9bf5b0 Compare July 10, 2024 14:51
@rousseldenis rousseldenis changed the title 17.0 mig stock restrict lot [17.0][MIG] stock_restrict_lot Jul 11, 2024
@StefanRijnhart
Copy link
Member

And I would be curious to know what you think about #1560.

@peluko00 peluko00 mentioned this pull request Jul 19, 2024
Open
@peluko00
Copy link

Any update @jcadhoc?

@jcadhoc
Copy link
Author

jcadhoc commented Jul 25, 2024

@rousseldenis Thanks for reminder, i will see it

@jcadhoc
Copy link
Author

jcadhoc commented Jul 25, 2024

@StefanRijnhart Sorry, i didnt see the older pr, for me its the same if i give +1 or we merge this, technically seems the same but my pr have precommit ok.

sanderlienaerts
sanderlienaerts approved these changes Jul 29, 2024
View reviewed changes
Copy link

@sanderlienaerts sanderlienaerts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migration seems OK.

@StefanRijnhart
Copy link
Member

@jcadhoc No, go ahead, the other PR is not responding. Can you check my other comments?

@sanderlienaerts sanderlienaerts mentioned this pull request Aug 2, 2024
Merged
@jcadhoc jcadhoc force-pushed the 17.0-mig-stock_restrict_lot branch from c9bf5b0 to fa25950 Compare August 5, 2024 17:22
@jcadhoc
Copy link
Author

jcadhoc commented Aug 5, 2024

@rousseldenis @StefanRijnhart All green this time!

Sorry for the delay, i think it's ok to merge, let mi know if i miss something else..

Thank you!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@StefanRijnhart
Copy link
Member

Thanks, looking good now. Please squash the last commit [IMP] : pre-commit auto fixes into the migration commit as it corrects the linting of a change in that commit.

@jcadhoc jcadhoc force-pushed the 17.0-mig-stock_restrict_lot branch from d9bb5c9 to 9687771 Compare August 6, 2024 13:25
@jcadhoc
Copy link
Author

jcadhoc commented Aug 6, 2024

@StefanRijnhart Ready!

Thanks for guide me :)

StefanRijnhart
StefanRijnhart approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@peluko00
Copy link

peluko00 commented Aug 7, 2024

It's ready for merge @StefanRijnhart?

peluko00
peluko00 approved these changes Aug 7, 2024
View reviewed changes
Copy link

@peluko00 peluko00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

@StefanRijnhart
Copy link
Member

@peluko00 Yes!

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-1652-by-StefanRijnhart-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f26376b into OCA:17.0 Aug 7, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 5971a5f. Thanks a lot for contributing to OCA. ❤️

This was referenced Aug 7, 2024
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peluko00 peluko00 peluko00 approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

@sanderlienaerts sanderlienaerts sanderlienaerts approved these changes

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review ready to merge
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.