[17.0][MIG] Migration of module purchase_lot #2331
Conversation
alan196
force-pushed
the
17.0-mig-purchase_lot
branch
from
fc07438 to
2108d1c
Compare
| @@ -19,7 +19,7 @@ | |||
| <field name="inherit_id" ref="purchase.purchase_order_line_form2" /> | |||
| <field name="arch" type="xml"> | |||
| <xpath expr="//field[@name='product_id']" position="after"> | |||
| <field name="lot_id" /> | |||
| <field name="lot_id" readonly="1" /> | |||
There was a problem hiding this comment.
What are your thoughts on moving the readonly attribute from the Python code to the XML-records?
| <field name="model">purchase.order</field> | ||
| <field name="inherit_id" ref="purchase.view_purchase_order_filter" /> | ||
| <field name="arch" type="xml"> | ||
| <xpath expr="//field[@name='name']" position="after"> |
There was a problem hiding this comment.
<field name="name" position="after"></field> should suffice
There was a problem hiding this comment.
I don't know how to do this... in previous PR's I use that approach, and the reviewers suggest me to use xpath.
I think this depends on preference and it will work the same way.
| <field name="model">purchase.order.line</field> | ||
| <field name="inherit_id" ref="purchase.purchase_order_line_form2" /> | ||
| <field name="arch" type="xml"> | ||
| <xpath expr="//field[@name='product_id']" position="after"> |
There was a problem hiding this comment.
We can replace the xpath expression by just using <field name="product_id" position="after"></field>
alan196
force-pushed
the
17.0-mig-purchase_lot
branch
from
2108d1c to
f86803f
Compare
|
|
|
@alan196 |
Translated using Weblate (Spanish) Currently translated at 100.0% (3 of 3 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_lot Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_lot/es/
Translated using Weblate (Italian) Currently translated at 100.0% (3 of 3 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_lot Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_lot/it/
alan196
force-pushed
the
17.0-mig-purchase_lot
branch
from
f86803f to
840152f
Compare
|
I have removed that commit and rebased, now is ready to review 👍 @sanderlienaerts |
This PR is ready to review