[17.0][MIG] base_tier_validation: Migration to 17.0 #787

celm1990 · 2023-12-27T21:31:49Z

superseded by #755

…on and validate if possible.

…ation records

* able to restart validation * sudo() not needed anymore

and reject can be hidden according to this computed field.

… and who asks for reviews in new fields 'done_by' and 'requested_by'.

fixup and extend tests [ADD] systray icon for pending reviews [FIX] Remove python safe_eval [ADD] base_tier_validation_formula and migration scripts [ADD] widget domain and python expression to define reviewer in tier definition [ADD] auto updating of systray icon counter [ADD] validation date field [ADD] review widget dropdown menu

…reviews' name and state correctly translated.

* using similar approach to activities has already benn addressed. * add a new point explaining review tooltip improvement possibilities.

celm1990 · 2023-12-28T19:31:35Z

@bosd @moitabenfdz @TonyMasciI @Duranio @pedrobaeza @gurneyalex
The PR is ready for review. I'll squash the commits before merging. For now, it is keep for an easy technical review.

bosd · 2023-12-28T20:11:54Z

@celm1990 Thanks so much for this PR.
Can you please include: 127ec31

In the other PR, I made a comment with the propossal to integrate the module base_tier_validation_waiting into this base module.
There was no feedback yet...
What is your opinion on this?

Motivation:

The base_tier_validation_waiting module might be "too simple" to be an independent module.
Mainting it separatly is kinda "costly" it needs some patches to make the unit tests pass. (by either separating the test of the module, or patching all other tier_validation modules)
Usability, when making (sequential) tier reviews it makes sense to have an clearoverview on the approval flow.
(Sequence approval is implemented in this base module as well)

celm1990 · 2023-12-28T20:44:03Z

@celm1990 Thanks so much for this PR. Can you please include: 127ec31

cherry-pick done

In the other PR, I made a comment with the propossal to integrate the module base_tier_validation_waiting into this base module. There was no feedback yet... What is your opinion on this?

I apologize, but I haven't worked with that module before, and I'm not familiar with its functionality. Additionally, I couldn't find available in versions 16 or 15. Introducing it might require additional migration efforts. I suggest focusing on the current migration for now. In a subsequent pull request, you could propose the integration of that module directly.

bosd · 2023-12-28T21:32:37Z

I apologize, but I haven't worked with that module before, and I'm not familiar with its functionality.

Sorry, forgot to mention a little bit of background info...

What the module does is quite simple. It adds another validation status waiting.
When reaching that status a notification can be sent out.
Use case: In sequential approval flow, you only want to sent out a notification to the approver when it is 'his' turn.

It's really small change, but because it is adding a status. It's kinda problematic and breaking tests.

Currently I have PR's open for base_tier_validation_waiting for version 15 and 16. (for quite some while now)
As per discussion in the pr of V15 #638 it become clear that unit tests of that module is kinda problematic.

I couldn't find available in versions 16 or 15. Introducing it might require additional migration efforts.

The testing problem
Could likely be the cause for not yet having this module merged into 15 and 16 branches.
There is no clean, neat and "oca" way to test it. I've discussed this with some dev's at the OXP 2023.
The options:

Change functionality when in test context (Dirty but works, current implementation)
Create an isolated testing runboat (very dirty hack. and not a real integration test)

The added actual migration effort is a good thing. 🤓
The best time to refactor is in a migration. As all the code for the depending modules need to be migrated anyway.
If we include it now, we take the pain once, and we know that all depending modules for V17 and onwards are compatible.

In a subsequent pull request, you could propose the integration of that module directly.

Doing the refactor in the "middle" of a release will break tests, CI/CD.
(Not only here on the OCA repo's but also on other partners). We will encounter issues when we have to versions of the base_tier_validation module.

Sorry, for thinking out loud a bit 😉
The more I think of it, I'm convinced it should be done in the migration to V17.

Preferrably, I would like to have an opinion on this matter from of one the more OCA expeirenced members / heavyweights. With a deeper understanding of these modules.
Is that where the PSC's are for??

We could also drag this "issue" along to next versions.
(But as V17 is not used in production yet, we might have a chance here.)

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-ux-16.0/server-ux-16.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_tier_validation/

Currently translated at 100.0% (114 of 114 strings) Translation: server-ux-16.0/server-ux-16.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_tier_validation/es/

- Include context keys for avoiding mail operations overhead.

… allow inheritance TT45804

celm1990 · 2024-01-09T05:07:42Z

@celm1990 You might need to squash all migration commits into one commit.

Done

bosd · 2024-01-09T07:39:08Z

Please include #724

base_tier_validation/security/ir.model.access.csv

nguyenminhchien · 2024-01-09T08:57:19Z

base_tier_validation/static/description/index.html

@@ -0,0 +1,593 @@
+<?xml version="1.0" encoding="utf-8"?>


I faced this warning, should remove this line

2024-01-09 08:42:30,778 12362 INFO v17c_base_tier_validation odoo.modules.registry: module base_tier_validation_formula: creating or updating database tables 2024-01-09 08:42:30,872 12362 WARNING v17c_base_tier_validation py.warnings: /home/chien/code/odoo/odoo/17.0/odoo/addons/base/models/ir_module.py:170: DeprecationWarning: XML declarations in HTML module descriptions are deprecated since Odoo 17, base_tier_validation_formula can just have a UTF8 description with not need for a declaration.

This one should be fixed when repo update in #798 is merged.

This is just a warning, @pedrobaeza do you have any plans to update the global OCA update copier after merging this PR OCA/oca-addons-repo-template#239?

Oh, I didn't remember that it was fixed at maintainer-tools level. @sbidoul has the token to update with the bot all the branches.

base_tier_validation/__manifest__.py

base_tier_validation/models/tier_validation.py

And some part of the field are not show.

celm1990 · 2024-01-09T22:20:26Z

@nguyenminhchien could you please update your review

pedrobaeza · 2024-01-10T07:32:38Z

/ocabot merge nobump

OCA-git-bot · 2024-01-10T07:32:48Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-787-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2024-01-10T07:36:41Z

Congratulations, your PR was merged at a4d6120. Thanks a lot for contributing to OCA. ❤️

bosd · 2024-01-10T07:47:02Z

Oops, this merge went quick.
The V17 comments where not yet adressed.
I was about to open the merge pr based on this one this evening.

Well, we can discuss that merge later in that pr 😉

Anyway big thanks @celm1990 for all your work on this pr!

LoisRForgeFlow and others added 22 commits December 5, 2023 07:42

[9.0][ADD] base_tier_validation

5b6e60b

fix: blocking unneded records

840861c

[9.0][IMP] base_tier_validation: tries automatically request validati…

a6e1598

…on and validate if possible.

[9.0][IMP] base_tier_validation: filter out reviews not pending

a294f41

make possible to filter by validated records

5abdbe9

allow to add exceptions for fields that can be written on under valid…

4e878db

…ation records

[9.0][IMP] base_tier_validation:

4de7df7

* able to restart validation * sudo() not needed anymore

[10.0][MIG] base_tier_validation

860ff11

[11.0][MIG] base_tier_validation

6a5e008

[11.0][IMP] base_tier_validation: add tests

ea6d573

add 'can_review' to tier.validation so that the buttons approve

79fc665

and reject can be hidden according to this computed field.

[11.0][IMP] base_tier_validation: enhance views and register who does…

2afa769

… and who asks for reviews in new fields 'done_by' and 'requested_by'.

[11.0][FIX] base_tier_validation

205ef3f

Add name attribute to filter

50c049a

[MIG] base_tier_validation: Migration to 12.0

a3c6278

[ADD] icon.png

59a5986

[IMP] base_tier_validation: Pass parameters as functions

2b8a6dd

[IMP] base_tier_validation: Add a chatter message if the model has it

f69529a

[11.0][FIX] base_tier_validation: make name translatable and display …

47a4fc1

…reviews' name and state correctly translated.

[11.0][UPD] base_tier_validation: roadmap.

529d834

* using similar approach to activities has already benn addressed. * add a new point explaining review tooltip improvement possibilities.

[12.0][MIG] base_tier_validation: adapt systray to v12.

82abb84

celm1990 mentioned this pull request Dec 28, 2023

[17.0][MIG] sale_tier_validation: Migration to 17.0 OCA/sale-workflow#2874

Merged

celm1990 marked this pull request as ready for review December 28, 2023 19:17

celm1990 mentioned this pull request Dec 28, 2023

[17.0][MIG] purchase_tier_validation: Migration to 17.0 OCA/purchase-workflow#2138

Merged

celm1990 force-pushed the 17.0-mig-base_tier_validation branch from 9a299fb to be4ecae Compare December 28, 2023 20:37

OCA-git-bot and others added 9 commits January 9, 2024 00:05

[BOT] post-merge updates

2c05767

Update translation files

1bcd349

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-ux-16.0/server-ux-16.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_tier_validation/

Translated using Weblate (Spanish)

507f919

Currently translated at 100.0% (114 of 114 strings) Translation: server-ux-16.0/server-ux-16.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_tier_validation/es/

[BOT] post-merge updates

604b107

[IMP] base_tier_validation: test performance improvement

b9171dd

- Include context keys for avoiding mail operations overhead.

[BOT] post-merge updates

2a78669

[IMP] base_tier_validation: Add _prepare_tier_review_vals() methot to…

d85c304

… allow inheritance TT45804

[BOT] post-merge updates

8c5c9dc

[IMP] base_tier_validation: pre-commit stuff

16ed501

celm1990 force-pushed the 17.0-mig-base_tier_validation branch from 285ade5 to bb5723c Compare January 9, 2024 05:06

nguyenminhchien suggested changes Jan 9, 2024

View reviewed changes

rven and others added 3 commits January 9, 2024 17:11

[MIG] base_tier_validation: Migration to 17.0

b2be450

base_tier_validation: only post notifications to reciepients

06101a9

[FIX] base_tier_validation: field is edtitable

5be3bb2

And some part of the field are not show.

celm1990 force-pushed the 17.0-mig-base_tier_validation branch from bb5723c to 5be3bb2 Compare January 9, 2024 22:12

nguyenminhchien approved these changes Jan 10, 2024

View reviewed changes

sonhd91 mentioned this pull request Jan 10, 2024

[MIG] base_tier_validation_formula: Migrate to version 17.0 #799

Merged

OCA-git-bot added the bot is merging ⏳ label Jan 10, 2024

OCA-git-bot merged commit f01e2ac into OCA:17.0 Jan 10, 2024

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jan 10, 2024

bosd mentioned this pull request Jan 10, 2024

[17.0][IMP] base_tier_validation: Merge module with base_tier_validation_waiting #800

Merged

celm1990 deleted the 17.0-mig-base_tier_validation branch January 12, 2024 13:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] base_tier_validation: Migration to 17.0 #787

[17.0][MIG] base_tier_validation: Migration to 17.0 #787

celm1990 commented Dec 27, 2023

celm1990 commented Dec 28, 2023

bosd commented Dec 28, 2023

celm1990 commented Dec 28, 2023

bosd commented Dec 28, 2023

celm1990 commented Jan 9, 2024

bosd commented Jan 9, 2024

nguyenminhchien Jan 9, 2024

bosd Jan 9, 2024

celm1990 Jan 9, 2024

pedrobaeza Jan 10, 2024

celm1990 commented Jan 9, 2024

pedrobaeza commented Jan 10, 2024

OCA-git-bot commented Jan 10, 2024

OCA-git-bot commented Jan 10, 2024

bosd commented Jan 10, 2024

[17.0][MIG] base_tier_validation: Migration to 17.0 #787

[17.0][MIG] base_tier_validation: Migration to 17.0 #787

Conversation

celm1990 commented Dec 27, 2023

celm1990 commented Dec 28, 2023

bosd commented Dec 28, 2023

celm1990 commented Dec 28, 2023

bosd commented Dec 28, 2023

celm1990 commented Jan 9, 2024

bosd commented Jan 9, 2024

nguyenminhchien Jan 9, 2024

Choose a reason for hiding this comment

bosd Jan 9, 2024

Choose a reason for hiding this comment

celm1990 Jan 9, 2024

Choose a reason for hiding this comment

pedrobaeza Jan 10, 2024

Choose a reason for hiding this comment

celm1990 commented Jan 9, 2024

pedrobaeza commented Jan 10, 2024

OCA-git-bot commented Jan 10, 2024

OCA-git-bot commented Jan 10, 2024

bosd commented Jan 10, 2024