Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] base_tier_validation: Migration to 17.0 #755

Closed
wants to merge 448 commits into from
Closed

[17.0][MIG] base_tier_validation: Migration to 17.0 #755

wants to merge 448 commits into from

Conversation

moitabenfdz
Copy link

No description provided.

@moitabenfdz moitabenfdz mentioned this pull request Nov 14, 2023
Open
24 tasks
@moitabenfdz moitabenfdz marked this pull request as ready for review November 14, 2023 09:24
@moitabenfdz moitabenfdz marked this pull request as draft November 14, 2023 09:42
@moitabenfdz moitabenfdz changed the title [17.0][MIG] base_tier_validation [17.0][MIG] base_tier_validation: Migration to 17.0 Nov 15, 2023
@Duranio
Copy link

Duranio commented Nov 28, 2023

@moitabenfdz Please, could you tell me why this PR is marked as draft and how long will it take to be ready for review?

@bosd
Copy link
Contributor

bosd commented Nov 28, 2023

I would like to open the discussion.
What do you think of merging base_tier_validation_waiting Into the base module for v17?

Imo it would simplify the code.

@moitabenfdz
Copy link
Author

@moitabenfdz Please, could you tell me why this PR is marked as draft and how long will it take to be ready for review?

I have found problems with the JS files. I don't know how long it will take me to fix them, as I have no experience with Odoo JS.

@TonyMasciI
Copy link

@moitabenfdz Please, could you tell me why this PR is marked as draft and how long will it take to be ready for review?

I have found problems with the JS files. I don't know how long it will take me to fix them, as I have no experience with Odoo JS.

Hi @moitabenfdz , can you share the errors with us?

@moitabenfdz
Copy link
Author

@TonyMasciI you can check them in the runboat. I didn't migrate JS files, and a lot of things in mail are changed from v16 to v17.

@bosd
Copy link
Contributor

bosd commented Nov 28, 2023

Additionally, before merging, please update this pr, to include the latest commits on V16.

oca-ci and others added 20 commits December 5, 2023 07:42
@rven
[UPD] Update base_tier_validation.pot
1da7f6c
@rven
[UPD] Update base_tier_validation.pot
6b51033
@rven
[UPD] Update base_tier_validation.pot
d156975
@rven
[UPD] Update base_tier_validation.pot
d89d732
@weblate @rven
Update translation files
af40850 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-ux-16.0/server-ux-16.0-base_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_tier_validation/
@rven
[UPD] Update base_tier_validation.pot
20af618
@weblate @rven
Update translation files
8f2b208 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-ux-16.0/server-ux-16.0-base_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_tier_validation/
@rven
[UPD] Update base_tier_validation.pot
9bbfd05
@weblate @rven
Update translation files
1285aad 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-ux-16.0/server-ux-16.0-base_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_tier_validation/
@rven
[UPD] Update base_tier_validation.pot
c8bb8d8
@weblate @rven
Update translation files
eaacaf5 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-ux-16.0/server-ux-16.0-base_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_tier_validation/
@rven
[UPD] Update base_tier_validation.pot
108549e
@weblate @rven
Update translation files
e673d29 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-ux-16.0/server-ux-16.0-base_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_tier_validation/
@rven
[UPD] Update base_tier_validation.pot
c86f8af
@rven
[UPD] Update base_tier_validation.pot
f8007e8
@mymage @rven
Translated using Weblate (Italian)
feb7685 
Currently translated at 77.1% (81 of 105 strings)

Translation: server-ux-16.0/server-ux-16.0-base_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_tier_validation/it/
@francesco-ooops @rven
Translated using Weblate (Italian)
b116876 
Currently translated at 77.1% (81 of 105 strings)

Translation: server-ux-16.0/server-ux-16.0-base_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_tier_validation/it/
@mymage @rven
Translated using Weblate (Italian)
5c72a1f 
Currently translated at 77.1% (81 of 105 strings)

Translation: server-ux-16.0/server-ux-16.0-base_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_tier_validation/it/
@rven
[UPD] Update base_tier_validation.pot
c79ebfb
@weblate @rven
Update translation files
d35c8b5 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-ux-16.0/server-ux-16.0-base_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_tier_validation/
OCA-git-bot and others added 18 commits December 5, 2023 07:42
@OCA-git-bot @rven
[BOT] post-merge updates
3e2d0bb
@rven
[UPD] Update base_tier_validation.pot
8ead3f2
@weblate @rven
Update translation files
692f70e 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-ux-16.0/server-ux-16.0-base_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_tier_validation/
@victoralmau @rven
[IMP] base_tier_validation: Add _prepare_tier_review_vals() methot to…
4f339dd 
… allow inheritance

TT45804
@rven
[UPD] Update base_tier_validation.pot
858a8dd
@rven
[UPD] Update base_tier_validation.pot
2c096e0
@OCA-git-bot @rven
[BOT] post-merge updates
e262a8c
@rven
[UPD] Update base_tier_validation.pot
7b6ad30
@weblate @rven
Update translation files
c59c3f0 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-ux-16.0/server-ux-16.0-base_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_tier_validation/
@rven
[UPD] Update base_tier_validation.pot
1d812fb
@weblate @rven
Update translation files
e9e64f3 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-ux-16.0/server-ux-16.0-base_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_tier_validation/
@rven
[UPD] Update base_tier_validation.pot
9ba572d
@weblate @rven
Update translation files
ec23b22 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-ux-16.0/server-ux-16.0-base_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_tier_validation/
@rven
[UPD] Update base_tier_validation.pot
33540ce
@weblate @rven
Update translation files
4dbcec8 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-ux-16.0/server-ux-16.0-base_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_tier_validation/
@rven
[UPD] Update base_tier_validation.pot
50add97
@weblate @rven
Update translation files
0a9e6ef 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-ux-16.0/server-ux-16.0-base_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_tier_validation/
@rven
[IMP] base_tier_validation: pre-commit stuff
41a6864
@rven rven force-pushed the 17.0-mig-base_tier_validation branch 3 times, most recently from 4255b04 to bb8334c Compare December 5, 2023 06:53
@pedrobaeza
Copy link
Member

Please squash administrative commits, as 448 commits seems a lot.

@rven rven force-pushed the 17.0-mig-base_tier_validation branch from bb8334c to e242cbf Compare December 5, 2023 07:19
@bosd
Copy link
Contributor

bosd commented Dec 5, 2023

What do you think of merging base_tier_validation_waiting Into the base module for v17?

@moitabenfdz
What is your opinion about including this base functionality into the core module?

@gurneyalex
Copy link
Member

/ocabot migration base_tier_validation

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Dec 8, 2023
@celm1990
Copy link
Contributor

@moitabenfdz can you update the is status of this PR please, I interested on this module is migrated to V17, could you comment if I can continue migration if necessary

@celm1990 celm1990 mentioned this pull request Dec 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.