[16.0][ADD] sale_loyalty_industry #2859
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simahawk
approved these changes
Dec 19, 2023
| 2, | ||
| "The promo offer is not applied to industry_B.", | ||
| ) | ||
| self.immediate_promotion_program.industry_ids = self.industry_B |
There was a problem hiding this comment.
these are all different cases, right? If yes, rule of thumb: define 1 method for each of them unless it gets too complicated w/ the setup
There was a problem hiding this comment.
Done splitted unit test in several ones
[IMP] sale_loyalty_industry: Split unit tests
santostelmo
force-pushed
the
16.0-add-sale_loyalty_industry
branch
from
8f3e35c to
cc1d0a4
Compare
|
Moved that PR to sale-promotion: OCA/sale-promotion#197 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module allow to restrict the industries in which the sale loyalty program applies.