[16.0][ADD] sale_loyalty_industry

[santostelmo]

This module allow to restrict the industries in which the sale loyalty program applies.

Note: Moved from sale-workflow OCA/sale-workflow#2859

[cyrilmanuel]

LGTM

[cyrilmanuel]

Hi @pedrobaeza can you make a review here please ?

[pedrobaeza]

I think this module is not needed if you use loyalty_partner_applicability (and its sales counterpart sale_loyalty_partner_applicability, which is more generic to filter partners by any condition (including the industry), and it's also done at rule level, not program level, which is more inline with the new v16 approach.

I know yours is more "direct", but it's very limiting and in the end, I think using the generic one will give more versatility to your customer.

[santostelmo]

I think this module is not needed if you use loyalty_partner_applicability (and its sales counterpart sale_loyalty_partner_applicability, which is more generic to filter partners by any condition (including the industry), and it's also done at rule level, not program level, which is more inline with the new v16 approach.

I know yours is more "direct", but it's very limiting and in the end, I think using the generic one will give more versatility to your customer.

I have tested this module sale_loyalty_partner_applicability and indeed it seems to cover the needs. But i'm afraid that this domain is hard for a odoo user to build. It's less user friendly.

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.