[16.0][MIG] sale_coupon_multi_gift>sale_loyalty_multi_gift: Migration to version 16.0

[pilarvargas-tecnativa]

Pendin from:

• [16.0][MIG] coupon_multi_gift>loyalty_multi_gift: Migration to version 16.0 #181

cc @Tecnativa TT44348

@chienandalu please review

[chienandalu]

When there's only one multi-gift promo the wizard doesn't pop up and ll the products are put into the order, even all the options.

When there are several, the wizards shows up, but I can't do anything with the options. What's the plan?

[pilarvargas-tecnativa]

When there's only one multi-gift promo the wizard doesn't pop up and ll the products are put into the order, even all the options.

In v16, the promotions that have as a reward a product to choose between several products have this behaviour, if there are not several promotions the wizard does not open and they apply as a reward the default product.

Also, in v13 and v15, this is the behaviour, the wizard is opened by the module sale_coupon_order_suggestion (which is not yet migrated) with the gift icon in the order line that is part of a promotion.

A test in v15, with the modules installed:

• sale_coupon_criteria_multi_product
• sale_coupon_multi_gift
• sale_coupon_selection_wizard
  The wizard does not open and the default product of the promotion is applied.

A promotion is configured in which buying a white table or a black table you get a lamp or a bin as a reward.

Without sale_coupon_order_suggestion there is no icon to open the wizard and it does not open by itself.

When there are several, the wizards shows up, but I can't do anything with the options. What's the plan?

When there are alternative products as rewards, the list shows the configured products on the left side and on the right side you can select the product to apply.

Tests in v16:
A promotion is configured in which when the rules are met it will give away a bin or a lamp.
When there is only one promotion applicable, the default product (in this case the bin) will be given as a reward:

When there are several promotions the wizard will open to select which promotion to apply and which product as a reward (same as in previous versions and same behaviour of odoo in v16):

If there are several products as a reward, they will be shown in the wizard to choose whether to apply the default one or select another one. Each line of the list is a reward product, as I said before, on the left side the options are shown and on the right side the selected one.

Description of the rewards of the promotion (2 gifts):

List of products configured in the promotion (same as in previous versions - 2 gifts, 1 unit of one and 2 units of another):

List shown in the wizard (2 products with their options):

Once the promotion is applied in the sales order we have two rewards, 1 unit of bin and 2 units of table.

[chienandalu]

• You're adding every option to the cart: that's not correct. You should add only the default one if you do it automatically
• The idea is to use the core wizard to hook our option choosing behavior so this module is now self containing.

[pilarvargas-tecnativa]

@chienandalu I have relaunched

When the dependency is merged I will remove the commits that do not correspond to the migration.

[chienandalu]

I'm getting errors when trying to apply it:

This is how it's configured

[pilarvargas-tecnativa]

I'm getting errors when trying to apply it:

Corrected! thanks

[pedrobaeza]

/ocabot migration sale_coupon_multi_gift

[pedrobaeza]

/ocabot merge nobump

[OCA-git-bot]

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-196-by-pedrobaeza-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 597322f. Thanks a lot for contributing to OCA. ❤️