[16.0][MIG] coupon_multi_gift>loyalty_multi_gift: Migration to version 16.0 #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pilarvargas-tecnativa
force-pushed
the
16.0-imp-loyalty_multi_gift
branch
from
9047592 to
595f223
Compare
|
/ocabot migration coupon_multi_gift |
pilarvargas-tecnativa
force-pushed
the
16.0-imp-loyalty_multi_gift
branch
from
595f223 to
ced71cb
Compare
pilarvargas-tecnativa
force-pushed
the
16.0-imp-loyalty_multi_gift
branch
6 times, most recently
from
b6d64f8 to
e847210
Compare
chienandalu
reviewed
Jan 19, 2024
There was a problem hiding this comment.
@pilarvargas-tecnativa I just added a commit to avoid the bug we have when creating the multi-gift lines. Check it and update relaunch the sale_loyalty_multi_gift CI
1 task
pilarvargas-tecnativa
force-pushed
the
16.0-imp-loyalty_multi_gift
branch
from
2013fb8 to
52b973b
Compare
|
@chienandalu I have incorporated here the test that checks the fix. |
|
Great 👍 |
- Added migration script - Adapt test - Adapt methods and views TT44321
In https://github.com/odoo/odoo/blob/69b1993fb45b76110c24f5189a0ecfe9eb59a2aa/addons/loyalty/models/loyalty_program.py#L409 there is a call convert_to_cache on reward_ids that causes that one2many create commands are called twice and thus we get a duplicated record as convert_to_cache executes the values commands. We need to trick the context in order to flag the calls and create the multi gift lines just once.
pilarvargas-tecnativa
force-pushed
the
16.0-imp-loyalty_multi_gift
branch
from
52b973b to
20b91be
Compare
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 74a28ad. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes: #162
cc @Tecnativa TT44321
@chienandalu please review