-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] sale_coupon_criteria_multi_product > sale_loyalty_criteria_multi_product: Migration to version 16.0 #185
[16.0][MIG] sale_coupon_criteria_multi_product > sale_loyalty_criteria_multi_product: Migration to version 16.0 #185
Conversation
4a9afa9
to
be7a29e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check tests
/ocabot migration sale_coupon_criteria_multi_product |
be7a29e
to
9d1a281
Compare
solved :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This functionality is already included in the rules of the program itself, I have indicated it in the context of the base module. I have considered duplicating that functionality.
I'm going to check it |
9d1a281
to
f828cce
Compare
ping @chienandalu |
Rebase and drop the deps commit |
…e to sale_loyalty_criteria_multi_product
f828cce
to
2cb792e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge nobump
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at b7f64fc. Thanks a lot for contributing to OCA. ❤️ |
Supersedes: #165
Pending from:
cc @Tecnativa TT44344
@chienandalu please review