Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] coupon_criteria_multi_product>loyalty_criteria_multi_product: Migration to version 16.0 #184

Merged
merged 4 commits into from
Feb 28, 2024
Merged

[16.0][MIG] coupon_criteria_multi_product>loyalty_criteria_multi_product: Migration to version 16.0 #184

merged 4 commits into from
Feb 28, 2024

Conversation

pilarvargas-tecnativa
Copy link
Contributor

Supersedes: #160

cc @Tecnativa TT44317

@chienandalu please review

@pilarvargas-tecnativa pilarvargas-tecnativa mentioned this pull request Nov 23, 2023
Merged
@pedrobaeza
Copy link
Member

/ocabot migration coupon_criteria_multi_product

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Nov 24, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 24, 2023
Open
15 tasks
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-imp-coupon_criteria_multi_product branch from 6f0cfe9 to 0e514f8 Compare November 26, 2023 15:31
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-imp-coupon_criteria_multi_product branch from 0e514f8 to 48f2552 Compare November 29, 2023 16:23
@pilarvargas-tecnativa pilarvargas-tecnativa mentioned this pull request Nov 29, 2023
Merged
1 task
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-imp-coupon_criteria_multi_product branch 2 times, most recently from 35cbd00 to 482e70c Compare December 4, 2023 11:44
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-imp-coupon_criteria_multi_product branch from 482e70c to 56e4827 Compare January 30, 2024 18:54
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-imp-coupon_criteria_multi_product branch 2 times, most recently from 60b8637 to c2145f8 Compare February 1, 2024 09:56
pedrobaeza
pedrobaeza approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-184-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 27, 2024
@OCA-git-bot
Merge PR #184 into 16.0
575c005 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza The merge process could not be finalized, because command twine check odoo_addon_loyalty_criteria_multi_product-16.0.1.0.0.2-py3-none-any.whl failed with output:

Checking 
odoo_addon_loyalty_criteria_multi_product-16.0.1.0.0.2-py3-none-any.whl: �[31mFAILED�[0m
�[31mERROR   �[0m `long_description` has syntax errors in markup and would not be        
         rendered on PyPI.                                                      
         line 51: Error: Unexpected indentation.                                
�[33mWARNING �[0m `long_description_content_type` missing. defaulting to `text/x-rst`.

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-184-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 27, 2024
@OCA-git-bot
Merge PR #184 into 16.0
7285fd7 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza The merge process could not be finalized, because command twine check odoo_addon_loyalty_criteria_multi_product-16.0.1.0.0.2-py3-none-any.whl failed with output:

Checking 
odoo_addon_loyalty_criteria_multi_product-16.0.1.0.0.2-py3-none-any.whl: �[31mFAILED�[0m
�[31mERROR   �[0m `long_description` has syntax errors in markup and would not be        
         rendered on PyPI.                                                      
         line 51: Error: Unexpected indentation.                                
�[33mWARNING �[0m `long_description_content_type` missing. defaulting to `text/x-rst`.

@pilarvargas-tecnativa
[IMP-FIX] sale_loyalty_criteria_multi_product: Continue migration to …
a261f59 
…16.0

- Migration scripts
- Adapt views and tests
- Set correct permissions
- Move loyalty.criteria(coupon.criteria) model from loyalty.program to loyalty.rule

TT44317
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-imp-coupon_criteria_multi_product branch from c2145f8 to a261f59 Compare February 28, 2024 07:13
pedrobaeza
pedrobaeza approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if it's enough:

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-184-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 03dcf25 into OCA:16.0 Feb 28, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9904d7e. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-imp-coupon_criteria_multi_product branch February 28, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chienandalu chienandalu chienandalu approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
6 participants
@pilarvargas-tecnativa @pedrobaeza @OCA-git-bot @chienandalu @stefan-tecnativa @ernesto-garcia-tecnativa